Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed adjustment to terminology on requests #130

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

dcoomber
Copy link
Member

I propose the following UI terminology changes relating to the new request dialog:

  1. Http --> REST
  2. Graphql --> GraphQL
  3. Form Url Encoded --> Form URL Encoded

@helloanoop
Copy link
Contributor

helloanoop commented Mar 19, 2023

Hi @dcoomber,
Agree with everything except changing Http -> REST
The reason being that people also use Bruno to perform SOAP requests using http call.

The primary reason for keeping graphql separately (although it also uses http underneath) was to switch to a user interface that is custom made for working with graphql api's

Can you change back the REST -> Http, the rest of the changes look good.

@dcoomber
Copy link
Member Author

Hi @helloanoop

Thank you for the additional information - I forgot completely about SOAP 🤦 .

I'll switch that option back to HTTP.

@helloanoop helloanoop merged commit ee8a3ea into usebruno:main Mar 20, 2023
@helloanoop
Copy link
Contributor

Merged!
Thanks @dcoomber !

@dcoomber dcoomber deleted the bugfix/request-dialog-terminology branch March 22, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants