Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/assertion result issue #133

Merged
merged 2 commits into from
Mar 19, 2023

Conversation

bharathbdev
Copy link

Which issue ticket is this pull request for, and is the ticket now complete?
https://github.com/usebruno/bruno/issues/**121** (Complete)

Briefly describe your change.
Issue : Assertions are still displayed in the Tests tab after deletion
After Fix: When we delete the assertion in the request tab, it is getting deleted in the Tests result tab too.

What parts of the application are affected by your change?
Tests result tab

How did you test your change? If relevant, which role(s) and/or customer configuration(s) did you use?
Created a request
Add assertions in Assert tab.
Save and execute request.
Assert results should display in Tests tab.

Now delete assertions using the garbage bin button.
Save and execute request.
Assert results are not displayed in Tests tab.

@helloanoop helloanoop merged commit 04c3c2d into usebruno:main Mar 19, 2023
@helloanoop
Copy link
Contributor

Thanks for this @bharathbdev
Congrats on your getting your fist PR merged! Welcome to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants