Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1920): Ignore redirect abortion emmited by loadUrl #1959

Merged
merged 1 commit into from Apr 9, 2024

Conversation

gustavokath
Copy link
Contributor

@gustavokath gustavokath commented Mar 29, 2024

Description

This changes fix an issue which happens during authorization process of OAuth2.0 with authorization code when loading the authorize user window of IdP which contain redirects. This redirects cause the window.loadUrl(url) function to throw an error due that the original requested page was not completely loaded.

try {
await window.loadURL(authorizeUrl);
} catch (error) {
reject(error);
window.close();
}

Such behaviour is explained on electron/electron#17526 and electron/electron#27574. Insomnia also faced this as they reported on this issue Kong/insomnia#5926

Current error:
316626192-46e5d5c5-22b6-4d8d-a6a0-ddf787481999

Fixes: #1920

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@helloanoop helloanoop merged commit 179c30b into usebruno:main Apr 9, 2024
@helloanoop
Copy link
Contributor

Merged!

Thank you @gustavokath !

This will go out in the 1.13.0 release. Please subscribe to Discord announcement channel to stay notified on the releases.

pietrygamat pushed a commit to pietrygamat/bruno that referenced this pull request Apr 16, 2024
pietrygamat pushed a commit to pietrygamat/bruno that referenced this pull request May 5, 2024
pietrygamat pushed a commit to pietrygamat/bruno that referenced this pull request May 6, 2024
pietrygamat added a commit to pietrygamat/bruno that referenced this pull request May 7, 2024
pietrygamat pushed a commit to pietrygamat/bruno that referenced this pull request May 7, 2024
pietrygamat pushed a commit to pietrygamat/bruno that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth2.0 Authorization Code fails to open login screen - Error: ERR_ABORTED (-3) loading
2 participants