fix(#1920): Ignore redirect abortion emmited by loadUrl #1959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes fix an issue which happens during authorization process of OAuth2.0 with authorization code when loading the authorize user window of IdP which contain redirects. This redirects cause the
window.loadUrl(url)
function to throw an error due that the original requested page was not completely loaded.bruno/packages/bruno-electron/src/ipc/network/authorize-user-in-window.js
Lines 75 to 80 in 1349a79
Such behaviour is explained on electron/electron#17526 and electron/electron#27574. Insomnia also faced this as they reported on this issue Kong/insomnia#5926
Current error:
Fixes: #1920
Contribution Checklist: