-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Augment default truststore by default, optionally limit to custom CA certs #2057
feature: Augment default truststore by default, optionally limit to custom CA certs #2057
Conversation
Hi @mjhcorporate and @helloanoop, here are the promised changes (see #1937). I created a new PR for this. |
…runo into feature/keep-default-ca-cli
The failing test of
|
@helloanoop, please, consider adding this PR for one of the next releases. It is done for 3 weeks. I just merged the branch with the latest updates of |
7dd9a96
to
de72cff
Compare
…runo into feature/keep-default-ca-cli
Did the rebase exercise again. Would be great to have this missing feature of the CLI component considered for the next release, @helloanoop. |
Thanks @slowjoe007 ! @lohit-1 Please you prioritise this for the upcoming release. |
Merged! Thanks for taking care of this @slowjoe007 ! |
…ustom CA certs (usebruno#2057) * feat: Allow default truststore extension on bru CLI * feat: augment default truststore by default, optionally limit to custom CA certs * feat: augment default truststore by default, optionally limit to custom CA certs * feat: Allow default truststore extension on bru CLI * feat: augment default truststore by default, optionally limit to custom CA certs
Continuation of PR #1937, considering the changes proposed in that PR.
Description
The change in feature #1863 did not cover the CLI feature of Bruno,
bru
. This feature adds that part and introduces a new command line option tobru
CLI to control the way custom CA certificates are handled: replace or extend the default truststore.The new CLI option is called
--ignore-truststore
and documented in both synopsis and readme.This new option only is in effect, if a custom CA certificate is specified via option
--cacert
.At the same time, this change inverts the default handling of specifying custom CA certificates in the GUI. Previously, the default truststore was replaced completely, if custom CA certificates had been specified. Now specifying custom CA certificates results in augmenting the default truststore: the setting "Keep default truststore" is selected by default.
Contribution Checklist:
Use system CA certificates and/or allow specifying additional CA certificates #1080