-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Multi-part requests: user should be able to set content-type for each part in a multi-part request. #1602 #2121
base: main
Are you sure you want to change the base?
Conversation
… for each part in a multi-part request. usebruno#1602
Ready for Review |
Hi @Its-treason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, functionality wise.
One thing I don't really like is how the (Content-Type=text/plain)
is just appended to the end. But I also understand, that it cannot be done better with the current Bru-Lang. Hope this can be refactored with the new Bru-Lang.
excited for this feature... it's almost a blocker for us in our abandonment of Postman. |
51afc5f
to
02e23df
Compare
# Conflicts: # packages/bruno-lang/v2/src/bruToJson.js # packages/bruno-lang/v2/src/jsonToBru.js
The tests are failing but they will pass as soon as this PR is merged. It is because I added a new route in the CLI test backend: |
Hi @helloanoop I fixed the conflicts and retested. |
Looking forward to this feature being merged - thanks for working on this @end3rbyte ! |
@end3rbyte Hi, I'm waiting for this feature, can I know when it will be reflected? |
🙏 @end3rbyte do the conflicts need to be resolved before the merge can happen? |
This feature and also sending raw files as a request, are our only holdbacks from switching to bruno, hopefully we can have these on main asap <3 @helloanoop |
Thank you all for your patience. The PR looks good overall. We are currently reviewing it and will provide an update in the next few days. |
# Conflicts: # packages/bruno-lang/v2/src/jsonToBru.js
I've sync and fixed the conflict |
@end3rbyte @helloanoop The �confict is said to have been fixed, so please merge. |
It's been 3+ weeks since the "merged in next few days". This feature is great and needed, any info on this? |
Bump? |
Any update on this? not in v1.34.2 for windows |
@end3rbyte @helloanoop |
Multi-part requests: user should be able to set content-type for each part in a multi-part request (Issues: #1602)
Fixes #1602
Description
An optional column "Content-Type" was added.
Example how the content type is saved in the .bru file:
Demo:
multipart.bruno.demo.mp4
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.