feat: path parameters #484

game5413 · 2023-10-09T14:38:31Z

Currently, for setting URL path parameter that have dynamic value such as ID only available with two options. First changing directly the URL path and using Vars Pre-Request or Collection Variables, on this PR add new section to manage path parameters for user to changing value alongside with query params at one a time or individually. Also to provide solution for #281 issue.

game5413 · 2023-10-09T14:47:29Z

@helloanoop can you please help me to check any place that i forgot to add path params ?

helloanoop · 2023-10-13T01:53:34Z

This is great! Long PR. Will get this in for the next release.

# Conflicts: # packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js # packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js # packages/bruno-lang/v2/src/bruToJson.js

# Conflicts: # packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js # packages/bruno-electron/src/ipc/network/prepare-request.js

gianpo86 · 2023-11-23T13:34:26Z

@game5413 Looking forward to see this feature, your branch has conflicts with main, could you check it please?

# Conflicts: # packages/bruno-lang/v2/src/bruToJson.js

edbrannin · 2023-12-07T18:49:54Z

packages/bruno-app/src/components/RequestPane/QueryParams/index.js

+        <table>
+          <thead>
+            <tr>
+              <td>Name</td>
+              <td>Value</td>
+              <td></td>
+            </tr>
+          </thead>


The Query and Param tables are very similar to each other. It might be worth extracting a component for them.

Props would be something like

items

readOnlyKeys

onChangeKey

onChangeValue

onAddRow

onRemoveRow

edbrannin · 2023-12-07T18:52:52Z

...o-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/index.js

@@ -25,6 +25,53 @@ const interpolateUrl = ({ url, envVars, collectionVariables, processEnvVars }) =
  });
 };

+const joinPathUrl = (url, paths) => {


Consider exporting this function and writing unit tests for it

1Mark · 2023-12-29T17:15:46Z

Can't wait for this to be merged 🎉

bsleczko · 2024-01-03T11:15:13Z

packages/bruno-app/src/components/RequestPane/QueryParams/index.js

@@ -14,6 +20,7 @@ const QueryParams = ({ item, collection }) => {
  const dispatch = useDispatch();
  const { storedTheme } = useTheme();
  const params = item.draft ? get(item, 'draft.request.params') : get(item, 'request.params');
+  const paths = item.draft ? get(item, 'draft.request.paths') : get(item, 'request.paths');


I am looking into this PR as I am very interested in having this feature in Bruno, sadly in no way am I capable of reviewing JS code.
However, regarding these changes, I would fear ambiguity (in future) coming from variable names.
To avoid it, you could introduce changes similar to the following idea:

[dir] QueryParams -> RequestParams

[var] params -> queryParams

[var] paths -> pathParams

benjaminrae · 2024-01-22T11:06:46Z

Any updates on this? Or any help required? This is the only feature that is stopping me from leaving Postman behind and adopting Bruno

# Conflicts: # docs/readme/readme_fr.md # packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js # packages/bruno-electron/src/ipc/network/prepare-request.js # readme.md

DrGrognon · 2024-01-31T10:20:53Z

Hello! I'm also super excited by this feature 😃 @game5413 is there any way we can help you on this PR ?

# Conflicts: # contributing.md # packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/index.js # packages/bruno-cli/src/runner/interpolate-vars.js # packages/bruno-electron/src/ipc/network/interpolate-vars.js

Fle9ma · 2024-02-16T10:06:56Z

Hi 👋🏻 I'm so happy about this that I can't wait for this PR to be merged, if I can help in any way, please let me know.

andrewgee · 2024-02-29T10:50:42Z

We'd really like this to be introduced to bruno as well! It's the one thing that's keeping us using Postman at the moment

o-ric · 2024-03-21T08:10:02Z

I'm also super excited by this feature, and this is also the missing feature that is stopping my team from adopting Bruno definitively.
But it seems that something is blocking this feature, as it has been in development for months now.
Any news on this ?

@helloanoop commented on Oct 13, 2023

This is great! Long PR. Will get this in for the next release.

pho3nixf1re · 2024-04-02T16:39:38Z

Looks like this has gone stale with time due to conflicts and failing tests. Is @game5413 OK with me cleaning this up and opening a new PR? Alternatively I could PR your branch for you to then update here.

gianpo86 · 2024-04-02T17:28:49Z

That would be awesome….anything for this to go ahead :) missing it massively

…

On Tue 2. Apr 2024 at 18:40, Matthew Turney ***@***.***> wrote: Looks like this has gone stale with time due to conflicts and failing tests. Is @game5413 <https://github.com/game5413> OK with me cleaning this up and opening a new PR? Alternatively I could PR your branch for you to then update here. — Reply to this email directly, view it on GitHub <#484 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALOWUQKDLFHSKGBJ7ADHCTY3LNODAVCNFSM6AAAAAA5Y5G46SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGU2DINBSHA> . You are receiving this because you commented.Message ID: ***@***.***>

helloanoop · 2024-04-30T10:06:27Z

Update: @lohxt1 is reviewing this. We will have this shipped by the end of this week.

helloanoop · 2024-05-13T10:15:43Z

I've merged this to a feature branch on Bruno's main repo.
We have to do some minor updates in the schema and then this should be GTG.

@sanjai0py please have the updates done in the next 2 days as discussed.

* feat: path parameters (#484) * add path parameters on bruno-app * add path parameters on bruno-cli * fix bruno-schema testing * fix generate request code not replace path parameter value --------- Co-authored-by: game5413 <febryanph10@gmail.com> Co-authored-by: Anoop M D <anoop.md1421@gmail.com> * feat: Refactor request parameter handling - Update prepare-request.js to filter and rename 'paths' to 'params' with type 'path' - Remove 'paths' from export.js and interpolate-vars.js - Update bru.js to use 'params' instead of 'path' - Update requestSchema in index.js to use 'keyValueWithTypeSchema' for 'params' Co-authored-by: game5413 <febryanph10@gmail.com> Co-authored-by: Anoop M D <anoop.md1421@gmail.com> * feat: Refactor request parameter handling * refactor: changes form the review * refactor: Refactor transformItemsInCollection handling * refactor: Refactor improved export/import functionalities * refactor: Remove console.log statement in bruToJson.js --------- Co-authored-by: game5413 <37659721+game5413@users.noreply.github.com> Co-authored-by: game5413 <febryanph10@gmail.com> Co-authored-by: Anoop M D <anoop.md1421@gmail.com>

* fix(#484): minor code fixes * code fixes * fixes for generateCode * var change * pr review fixes

* feat: path parameters (usebruno#484) * add path parameters on bruno-app * add path parameters on bruno-cli * fix bruno-schema testing * fix generate request code not replace path parameter value --------- Co-authored-by: game5413 <febryanph10@gmail.com> Co-authored-by: Anoop M D <anoop.md1421@gmail.com> * feat: Refactor request parameter handling - Update prepare-request.js to filter and rename 'paths' to 'params' with type 'path' - Remove 'paths' from export.js and interpolate-vars.js - Update bru.js to use 'params' instead of 'path' - Update requestSchema in index.js to use 'keyValueWithTypeSchema' for 'params' Co-authored-by: game5413 <febryanph10@gmail.com> Co-authored-by: Anoop M D <anoop.md1421@gmail.com> * feat: Refactor request parameter handling * refactor: changes form the review * refactor: Refactor transformItemsInCollection handling * refactor: Refactor improved export/import functionalities * refactor: Remove console.log statement in bruToJson.js --------- Co-authored-by: game5413 <37659721+game5413@users.noreply.github.com> Co-authored-by: game5413 <febryanph10@gmail.com> Co-authored-by: Anoop M D <anoop.md1421@gmail.com>

* fix(usebruno#484): minor code fixes * code fixes * fixes for generateCode * var change * pr review fixes

game5413 added 4 commits October 9, 2023 21:27

add path parameters on bruno-app

251b0dc

add path parameters on bruno-cli

db5733b

Merge branch 'main' into feature/path-parameters

16212b7

fix bruno-schema testing

c341180

game5413 added 2 commits October 13, 2023 21:42

fix generate request code not replace path parameter value

4f92313

Merge branch 'main' into feature/path-parameters

f04c7aa

# Conflicts: # packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js # packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js # packages/bruno-lang/v2/src/bruToJson.js

helloanoop added this to the v1 milestone Oct 18, 2023

Merge branch 'main' into feature/path-parameters

6e05d12

# Conflicts: # packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js # packages/bruno-electron/src/ipc/network/prepare-request.js

kaiserkiwi mentioned this pull request Oct 31, 2023

Feature idea: path parameters and test data #281

Closed

Merge branch 'main' into feature/path-parameters

d928d74

# Conflicts: # packages/bruno-lang/v2/src/bruToJson.js

edbrannin reviewed Dec 7, 2023

View reviewed changes

RemekGdansk mentioned this pull request Dec 28, 2023

Support for path parameters #852

Closed

bsleczko reviewed Jan 3, 2024

View reviewed changes

Merge branch 'main' into feature/path-parameters

051df58

# Conflicts: # docs/readme/readme_fr.md # packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js # packages/bruno-electron/src/ipc/network/prepare-request.js # readme.md

sanjai0py added the pr-feature label Apr 1, 2024

sanjai0py self-assigned this May 11, 2024

helloanoop changed the base branch from main to feat/path-parameters May 13, 2024 10:10

Merge branch 'feat/path-parameters' into feature/path-parameters

2c373eb

helloanoop merged commit 2e71e60 into usebruno:feat/path-parameters May 13, 2024

lohxt1 added a commit to lohxt1/bruno that referenced this pull request May 30, 2024

fix(usebruno#484): minor code fixes

4471cf0

helloanoop pushed a commit that referenced this pull request May 30, 2024

fix/path param (#2388)

470d162

* fix(#484): minor code fixes * code fixes * fixes for generateCode * var change * pr review fixes

chrisnagel mentioned this pull request Jun 24, 2024

[Issue] CLI ignores path params in request-urls #2506

Closed

2 tasks

ThenTech mentioned this pull request Jun 28, 2024

[Issue] Path parameters are added as URL search parameters (v1.19.0) #2528

Closed

2 tasks

jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024

fix/path param (usebruno#2388)

5aff072

* fix(usebruno#484): minor code fixes * code fixes * fixes for generateCode * var change * pr review fixes

TPuetz97 mentioned this pull request Nov 6, 2024

Added path param & refactored query param usebruno/bruno-docs#145

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: path parameters #484

feat: path parameters #484

game5413 commented Oct 9, 2023 •

edited

Loading

game5413 commented Oct 9, 2023

helloanoop commented Oct 13, 2023

gianpo86 commented Nov 23, 2023

edbrannin Dec 7, 2023

edbrannin Dec 7, 2023

1Mark commented Dec 29, 2023

bsleczko Jan 3, 2024

benjaminrae commented Jan 22, 2024

DrGrognon commented Jan 31, 2024

Fle9ma commented Feb 16, 2024

andrewgee commented Feb 29, 2024

o-ric commented Mar 21, 2024

pho3nixf1re commented Apr 2, 2024

gianpo86 commented Apr 2, 2024 via email

helloanoop commented Apr 30, 2024

helloanoop commented May 13, 2024 •

edited

Loading

feat: path parameters #484

feat: path parameters #484

Conversation

game5413 commented Oct 9, 2023 • edited Loading

game5413 commented Oct 9, 2023

helloanoop commented Oct 13, 2023

gianpo86 commented Nov 23, 2023

edbrannin Dec 7, 2023

Choose a reason for hiding this comment

edbrannin Dec 7, 2023

Choose a reason for hiding this comment

1Mark commented Dec 29, 2023

bsleczko Jan 3, 2024

Choose a reason for hiding this comment

benjaminrae commented Jan 22, 2024

DrGrognon commented Jan 31, 2024

Fle9ma commented Feb 16, 2024

andrewgee commented Feb 29, 2024

o-ric commented Mar 21, 2024

pho3nixf1re commented Apr 2, 2024

gianpo86 commented Apr 2, 2024 via email

helloanoop commented Apr 30, 2024

helloanoop commented May 13, 2024 • edited Loading

game5413 commented Oct 9, 2023 •

edited

Loading

helloanoop commented May 13, 2024 •

edited

Loading