Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed editors style to avoid overflow #912

Conversation

LeonardoMussato
Copy link

Description

I noticed that on the JSON editor when it opens it shifts the layout and the entire page becomes scrollable. Now with these fixes, I changed all the heights of the editors to avoid defined values similar to calc(100vh - 22px) and use only height: 100% and display flex. The change is visible on the bottom of the page.

Before

Screenshot 2023-11-07 at 13 01 08

After

Screenshot 2023-11-07 at 13 01 35

Contribution Checklist:

  • [ X ] The pull request only addresses one issue or adds one feature.
  • [ X ] The pull request does not introduce any breaking changes
  • [ X ] I have added screenshots or gifs to help explain the change if applicable.
  • [ X ] I have read the contribution guidelines.
  • [ X ] Create an issue and link to the pull request.

Issue: #911

@helloanoop
Copy link
Contributor

Thanks for taking time to work on this @LeonardoMussato !

This issue is resolved as per #2758
Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants