Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): apply insert ops for postgres sink when pk is missing #15

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

le-vlad
Copy link
Contributor

@le-vlad le-vlad commented Jan 7, 2024

Change Type

Define the type of change your pull request will bring to the repo

  • Change Request
  • Bug Fix
  • New Feature
  • Documentation

Breaking Changes

Does your pull request introduce breaking changes?

  • Yes, this pull request will introduce breaking changes
  • No, no breaking changes will be introduced

Description

Previously, we expected the schema to have a pk for the record.
So prev implementation couldn't work when we didn't have pk from Sources like WebSocket

Testing

Describe how you have tested the changes or how we should test the changes:

  • I have added new tests for my changes
  • I have successfully run and passed all tests with my changes locally
  • I have not added any testing

Checklist

Please confirm the following:

  • I have made sure all new and existing tests passed
  • I have updated any necessary documentation
  • I have ensured all commits are neat and tidy

Reviewers

Please add any appropriate reviewers for your PR.

Additional context

PR closes #14

@le-vlad le-vlad self-assigned this Jan 7, 2024
@le-vlad le-vlad merged commit 5590ab6 into main Jan 7, 2024
1 check passed
@le-vlad le-vlad deleted the fix/postgres-insert-with-no-pk branch January 7, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres Sink requires at least one PK column to execute statements
1 participant