pg: Fix { $val: null } without $put: true #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Previously, this combination did not work (it would delete the property as if
null
was written, not{ $val: null }
). This behavior was inconsistent with Graffy semantics.Changes:
The root cause of the bug was the use of the Postgres
jsonb_strip_nulls()
function, which recursively removed nulls; the behavior we wanted was a shallow version of this.As no built-in function exists with the behavior we want, uses of jsonb_strip_nulls was replaced with the following subquery:
where $object is an expression returning a JSON object whose null properties are to be removed.
Additional changes to simplify the generated SQL:
nullif()
function (which converts an empty object to null), where we are certain that the object cannot be empty.