feat: decentralization setup #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutermont
reviewed
Aug 5, 2021
Comment on lines
32
to
33
|
|
||
|
|
woutermont
reviewed
Aug 5, 2021
Comment on lines
30
to
+36
| const server: NodeHttpServer = await manager.instantiate('urn:semcom-node:default:NodeHttpServer', { variables }); | ||
| const peerSyncScheduler: Scheduler = await manager.instantiate('urn:semcom-node:default:PeerSyncScheduler', { variables }); | ||
| const storageSyncScheduler: Scheduler = await manager.instantiate('urn:semcom-node:default:StorageSyncScheduler', { variables }); | ||
|
|
||
| server.start(); | ||
| peerSyncScheduler.start(); | ||
| storageSyncScheduler.start(); |
There was a problem hiding this comment.
Hmm... does this work? I.e. are the schedulers the same objects used for the init of the server, not new ones?
There was a problem hiding this comment.
when I tested it, the server didn't instantiate the 2 schedulers at all, because they aren't needed I think? The only thing they need to share is memoryStorage and apparently that happens because it synchronizes when I launch 2 nodes
woutermont
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.