PA-22055 Add Packages #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rafet
commented
Aug 24, 2023
•
rafet
commented
- codeerr
- requester
- simpleroute
sezaakgun
reviewed
Aug 24, 2023
sezaakgun
reviewed
Aug 24, 2023
sezaakgun
reviewed
Aug 24, 2023
insrequester/README.md
Outdated
|
|
||
| ```go | ||
| timeoutSeconds := 30 | ||
| requester.WithTimeout(timeoutSeconds) |
There was a problem hiding this comment.
burada request'in kendi timeout'u olduğu, overridable olduğunu not etmek iyi olur.
There was a problem hiding this comment.
overridable olmali :D
There was a problem hiding this comment.
şöyle düşünmüştüm.
- requester'in default timeout'u var. - bunu açık ifade edebilirsin.
- default'u istediğin sayıya setleyebiliyorsun WithTimeout diyerek. - bu zaten yazdın.
- request gönderirken, sadece o request için requester'in default'unu override edebiliyorsun. - bu özellik kodda yok gibi
There was a problem hiding this comment.
timeout request'e degil requester'a ozel olmali bence. o yuzden her is icin ayri requester aciyoruz. kullandigimiz pakette oyle bi ozellik yok baktigim kadariyla. requester'a ne veriyosan onu kullaniyo. request'in timeout'una bakmiyo
sezaakgun
approved these changes
Aug 25, 2023
|
bu insrequester go-pkg-private da da versiyon çakışması yaratıyor sanırım, şu an 4 ayrı requester var bunları birleştirmemiz lazım :D |
|
@rafet assignee pls |
Jamil-Najafov
approved these changes
Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.