Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition when running tests in parallel #1506

Closed
smlx opened this issue Dec 19, 2019 · 1 comment · Fixed by #1516
Closed

Race condition when running tests in parallel #1506

smlx opened this issue Dec 19, 2019 · 1 comment · Fixed by #1516
Labels
6-images-testing Base Images & Testing subsystem

Comments

@smlx
Copy link
Member

smlx commented Dec 19, 2019

Describe the bug
https://lagoon-ci.amazeeio.cloud/blue/organizations/jenkins/lagoon/detail/PR-1428/8/pipeline/68/

Recreating jenkinslagoonpr14288_logs2rocketchat_1 ... error
ERROR: for jenkinslagoonpr14288_logs2rocketchat_1  Renaming a container with the same name as its current name

ERROR: for logs2rocketchat  Renaming a container with the same name as its current name
Encountered errors while bringing up the project.
Makefile:118: recipe for target 'tests/node' failed
make: *** [tests/node] Error 1
make: *** Waiting for unfinished jobs....

To Reproduce
It's a race condition, so it doesn't always manifest. However running make tests -j2 will suffice.

Expected behavior
Tests should be able to reliably run in parallel.

Screenshots
n/a

Additional context
docker/compose#6704 indicates that it happens when running docker-compose up on the same container in parallel.

Looking at these targets in the Makefile, they run docker-compose up on the same containers, and will be run in parallel:

  • $(run-rest-tests)
  • tests/drupal tests/drupal-postgres tests/drupal-galera
  • $(run-webhook-tests)
@seanhamlin seanhamlin added the 6-images-testing Base Images & Testing subsystem label Jan 9, 2020
@fronbasal
Copy link

I experienced the same issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants