Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments page can have so many deployments that the page fails to load #2158

Closed
seanhamlin opened this issue Aug 19, 2020 · 2 comments
Closed
Labels
1-api-auth API & Authentication subsystem bug

Comments

@seanhamlin
Copy link
Contributor

seanhamlin commented Aug 19, 2020

Describe the bug

If you have a lot of deployments on a given environment, then loading the deployments page will take a long time. This can exceed 90 seconds, and thus the page will fail to load entirely.

On an active project 1,193 deployments are on the page. This is far too many to be useful.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new environment
  2. Trigger 1,000 deployments
  3. Notice how the page takes a long time to load

Expected behavior

Either A):

Pagination showing the last 20 deployments by default, with the option to go to the next page. The page should load in a reasonable time as well (sub 5 seconds) for a customer

or B):

Just limit the list of the last X entries, and don't do pagination. There should be no need to go back past 100 deployments (as an example) ever.

Screenshots

image

@chandanatk
Copy link

Related to #1382

@rocketeerbkw
Copy link
Member

We did option b in #2763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-api-auth API & Authentication subsystem bug
Projects
None yet
Development

No branches or pull requests

3 participants