Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to disable autogenerated routes on a specific environment #2863

Closed
shreddedbacon opened this issue Oct 14, 2021 · 1 comment
Closed
Labels
2-build-deploy Build & Deploy subsystem

Comments

@shreddedbacon
Copy link
Member

Our documentation says how we can enable autogenerated routes on a specific environment here but it isn't possible to enable autogenerated routes for all environments, but disable them on a specific environment.

Looking at the logic here, and given the following .lagoon.yml it appears that the ROUTES_AUTOGENERATE_ENABLED value will still be set to true, even though the branch has been set to be false

routes:
  autogenerate:
    enabled: true
environments:
  main:
    autogenerateRoutes: false

We should probably add something to check if it is specifically set to false too, something like this perhaps

if [[ "$ROUTES_AUTOGENERATE_BRANCH" == "false" ]]; then
  ROUTES_AUTOGENERATE_ENABLED=false
fi
@shreddedbacon
Copy link
Member Author

I believe this is now fixed in the build-deploy-tool, will update once confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-build-deploy Build & Deploy subsystem
Projects
None yet
Development

No branches or pull requests

3 participants