-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New webhook triggers for subscriptions and customers #440
Comments
Hi @mnida! If this issue is still available, I would like to work on it. After cloning the repo and poking around the codebase for a while, I found a few files that look like a good starting point for adding new webhooks. Backend:
Frontend: Do you have a recommendation for other files (either backend or frontend) to look into that will require editing for adding new webhooks? Cheers, |
@djanda97 Great! Yep this issue is still available! You should be all set on the frontend side beside that DeveloperTab you pointed out. Looping in @diego-escobedo to check if there is anything else on the backend. |
Hey David! Sorry for the late response, missed this one. Looks like the right path for the backend. I'll add in a few other things you might find useful.
In terms of where you'd actually be putting the
Doing all of the webhooks at once might be too much to chew off / review in a single PR, so perhaps spinning them out one issue at a time might end up being easier. Let me know if you need any more details or if you're curious about how the webhooks work in more detail! Happy to discuss. |
Thanks for the info! I agree that trying to implement all the new webhooks would be a bit much to tackle in a single PR, so I'll start with the customer created webhook & reach out when I have any questions after diving into the code! |
Hey @djanda97 checking in to see how the issue is going? |
Hi @mnida, so far so good! I've created a draft PR that registers the customer created webhook with the webhook server (svix) and adds it to the |
Great! Awesome to hear and excited to review next week. |
Now that #539 is merged, could the subscription related webhooks be split up into different issues so that they could be worked on individually? I would be interested in implementing a few more now that I've done it once before and know the general locations where code would need to be added 😄 |
Yeah! @djanda97 Feel free to create some more issues, we treated this one as just customer-created. You can use the same issue format and create and self-assign to as many as you are up for! |
Is your feature request related to a problem? Please describe.
Users want webhooks for these events:
Describe the solution you'd like
In the backend add this webhook functionality using our alerts framework and svix.
In the frontend simply add the checkbox in the create webhook url form.
The text was updated successfully, but these errors were encountered: