Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook for customer creation #539

Merged
merged 15 commits into from
Feb 19, 2023

Conversation

djanda97
Copy link
Contributor

@djanda97 djanda97 commented Feb 10, 2023

Fixes #440

Tasks:

  • Register new webhook with webhook server (svix)
  • Implement new webhook (frontend & backend)
  • Update documentation

@diego-escobedo
Copy link
Collaborator

Looks great so far, let me know if you need any help

@djanda97
Copy link
Contributor Author

djanda97 commented Feb 16, 2023

I modeled the customer creation webhook after code for existing webhooks, so I think I've made changes to all the necessary files, but I still need to test these changes and double check that the parameters passed to the serializers, webhook methods, etc. are correct.

@mnida
Copy link
Collaborator

mnida commented Feb 16, 2023

Awesome David @djanda97 . I think after you push this out it will be really simple for anyone to add new webhooks in as the framework will be set and easily repeatable (obviously depending on what the webhook tracks).

@djanda97
Copy link
Contributor Author

After starting up the application, I verified that the new checkbox appears on the Developer Settings tab, so I think the frontend portion is complete:

image

However, I could use some assistance to help verify that the backend is wired up correctly for the new webhook 😄

@djanda97 djanda97 marked this pull request as ready for review February 17, 2023 04:11
@djanda97 djanda97 temporarily deployed to Development February 17, 2023 04:24 — with GitHub Actions Inactive
@diego-escobedo diego-escobedo temporarily deployed to Development February 18, 2023 07:02 — with GitHub Actions Inactive
@mnida mnida temporarily deployed to Development February 18, 2023 20:44 — with GitHub Actions Inactive
@diego-escobedo diego-escobedo temporarily deployed to Development February 19, 2023 20:52 — with GitHub Actions Inactive
@diego-escobedo diego-escobedo merged commit 0fc12d0 into uselotus:main Feb 19, 2023
@diego-escobedo
Copy link
Collaborator

Fixed some stuff up but looks ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New webhook triggers for subscriptions and customers
3 participants