Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] how to make list-[checks|rulesets] work from git #75

Closed
wants to merge 1 commit into from

Conversation

jpopelka
Copy link
Member

When one runs list-checks -r or list-rulesets directly from git repo one gets:

File "/home/jpopelka/git/user-cont/colin/colin/core/ruleset/ruleset.py", line 208, in get_ruleset_directory
    raise ColinRulesetException(msg)
colin.core.exceptions.ColinRulesetException: Ruleset directory cannot be found.

We can either hack get_ruleset_directory() to discover also local (in git repo) rulesets/ or add a notice into README.

@lachmanfrantisek
Copy link
Member

There is a more general problem with directories --for now, it used one or another, but not merge the content.

In case of the list-ruleset it would be nice to look at:

  • ./rulesets/
  • .local/share/colin/rulesets/
  • /usr/local/share/colin/rulesets/

If one of these directories does not exist, no error will be raised. (Conflicts will be overwritten global -> local -> current directory.)
Finally, all found files will be returned.

@TomasTomecek
Copy link
Member

TomasTomecek commented Apr 10, 2018

+1

I also agree on documenting such behavior.

@lachmanfrantisek
Copy link
Member

Yesterday, we are discussing this problem and got with the following:

  1. For now, use first valid from the folllowing
  • ./rulesets
  • .local/share/colin/rulesets/
  • /usr/local/share/colin/rulesets/
  1. In the future, use all of them.

@TomasTomecek
Copy link
Member

I am going to close this; I opened #106 to track what Franta wrote and my PR #104 actually addresses this.

@jpopelka once #104 is merged, please check whether it resolves your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants