refactor(packages) Update spec #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
9renpoto
force-pushed
the
fix/examples
branch
2 times, most recently
from
ef231d1
to
0285ab8
Compare
Surgo
reviewed
Mar 20, 2018
packages/userdive/README.md
Outdated
| ```js | ||
| import factory from "userdive"; | ||
|
|
||
| const myTracker = factory("myTracker"); // customize global name |
There was a problem hiding this comment.
global function name as same as agent.js doc
9renpoto
changed the title
added 6 commits
March 22, 2018 11:55
shoota
reviewed
Mar 22, 2018
packages/linker/README.md
Outdated
|
|
||
| [](https://saucelabs.com/open_sauce/user/userdive/builds) | ||
|
|
||
| > TBA | ||
| > CORS domain tracking using query parameter plugin |
There was a problem hiding this comment.
CORS means cross origin, including difference port. I think that it should not fit here.
9renpoto
commented
Mar 22, 2018
| _ud("require", 'linker'); | ||
| _ud("send", "pageview"); | ||
| _ud("linker", "autoLink", ['developers.userdive.com']); | ||
| script(src="https://cdn.userdive.com/linker.js") | ||
| _ud("linker:autoLink", ['developers.userdive.com']); |
Surgo
reviewed
Mar 22, 2018
packages/linker/README.md
Outdated
|
|
||
| [](https://saucelabs.com/open_sauce/user/userdive/builds) | ||
|
|
||
| > TBA | ||
| > Cross-domain tracking tracking using query parameter plugin |
opapy
previously approved these changes
Mar 22, 2018
opapy
approved these changes
Mar 22, 2018
Surgo
approved these changes
Mar 22, 2018
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 90.38% 90.75% +0.36%
==========================================
Files 19 19
Lines 499 573 +74
Branches 83 112 +29
==========================================
+ Hits 451 520 +69
Misses 27 27
- Partials 21 26 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Closes #376