Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translation inside Handlebar tables #624

Closed
lcharette opened this issue Jan 22, 2017 · 4 comments
Closed

Missing translation inside Handlebar tables #624

lcharette opened this issue Jan 22, 2017 · 4 comments
Labels
internationalization Related to the localization feature todo Generic task
Milestone
4.x

Comments

@lcharette
Copy link
Member

One of the last missing translations are in the Handlebar tables. See for example : app/sprinkles/admin/templates/components/tables/groups.html.twig.

The problem is the Twig translate function is not available inside the verbatim block.
@lcharette lcharette added internationalization Related to the localization feature todo Generic task labels Jan 22, 2017
@lcharette lcharette added this to the 4.0 milestone Jan 22, 2017
@alexweissman
Copy link
Member

Not sure if this is helpful or not: http://twig.sensiolabs.org/doc/2.x/recipes.html#using-twig-and-angularjs-in-the-same-templates

@lcharette
Copy link
Member Author

lcharette commented Jan 23, 2017 •
edited
Loading

Escaping the {{ doesn't work :(

So maybe changing Handlebar to {[...

@lcharette
Copy link
Member Author

Turns out the solution is even easier : {% endverbatim %}{{translate("DESCRIPTION")}}{% verbatim %}

lcharette added a commit that referenced this issue Jan 23, 2017
@lcharette
Fix #624
7fdf76c
@alexweissman
Copy link
Member

Lol, that will do it I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internationalization Related to the localization feature todo Generic task
Projects
None yet
Milestone
4.x
Development

No branches or pull requests
2 participants
@lcharette @alexweissman