Biscuit does not export yaml, so don't yaml-parse it #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes people have spaces in their paths
backwards compatible. I think it's reasonable to assert that nobody could be depending on the biscuit gem to re-interpret their encrypted strings by YAML-parsing and to_s-ing them
jerrod
approved these changes
May 16, 2018
|
|
||
| context "when the values look like arrays" do | ||
| let(:exported_data) { "foo: 1,2,3,4,5" } | ||
| let(:expected_hash) { Hash["foo" => "1,2,3,4,5"] } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I discovered in an Uploader PR (to move stuff from CF to biscuit) that
LEGACY_INITIALIZATION_VECTORhad some kind of problem after I moved it. Investigation showed that, when Ibiscuit put -f FILE LEGACY_INITIALIZATION_VECTOR 1,2,3,4,5, the actual envar being supplied back by biscuit in staging was"12345".When I dug into the details, this turned out to be because
biscuit exportis printing out its data in a rawKEY: VALUEformat, which is not actually YAML, but resembles it strongly. We YAML-parse the output of that file, which results in getting an Array value for that key, and then cast it to a string in the library.While my initial reaction was to just switch to using some other separator that YAML doesn't care about, I think this is a gotcha that will catch others, especially since biscuit doesn't actually get used locally.
Changes
YAML.load(use raw string-splitting instead)