Added support for using the root certificates of the os #229
Conversation
| @@ -102,7 +102,7 @@ function getJavaCandidates(): string[] { | |||
| } | |||
| } | |||
| } | |||
| return result; | |||
| return [];//result; | |||
There was a problem hiding this comment.
nope, this is debugging code, I wanted to trigger it on my machine. good find.
| @@ -20,9 +20,11 @@ | |||
| "url": "https://github.com/usethesource/rascal-language-servers" | |||
| }, | |||
| "dependencies": { | |||
| "mac-ca": "^1.0.6", | |||
There was a problem hiding this comment.
dependency added but not used?
There was a problem hiding this comment.
it's imported, that's enough.
see the comment:
import * as macca from 'mac-ca'; // just importing is is enough
|
|
||
| // help typescript accept that it's all "any" | ||
| declare module 'win-ca'; | ||
| declare module 'mac-ca'; |
There was a problem hiding this comment.
don't see where this is used yet. pls help
There was a problem hiding this comment.
well, typescript doesn't want to import modules without type definitions. but you can add a defintion for a module that roughly says: stop type-checking, everything is any. This file does that.
|
Thanks for the review, I'm waiting for some feedback on this downstream issue: ukoloff/win-ca#48 after that it either fixed or closed, we can choose to do this. else the downloader will sadly fail on any https-mitm-firewall-enterprise environments. |
|
Ok that's great. I need to learn what to do for Mac by reading the code of the import you did. Let's merge this branch asap. |
|
I think we should move to this library: https://github.com/microsoft/vscode-windows-ca-certs in combination with https://github.com/microsoft/vscode-proxy-agent |
|
After some discussion with VS developers, they told me that vscode is already patching all nodejs processes to import the root certificate. I've tested this by installing a custom CA root in my own machine. and indeed, it just works as you would expect. I'm closing this PR. @jurgenvinju we need to ask the users that reported this to provide a bit more information about their corporate firewall setup. |
Sometimes, company firewalls like to inspect https traffic. To do that they insersect https traffic, and re-sign the traffic with a private certificate authority.
This code makes sure we import local certificate authorities.