-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large blank space at the bottom of modals #85
Comments
AsideThe upcoming "free-form surveys" solution reinforces the use of the "mainsheet" pattern, which is particularly useful for interactions like "Add field," where there's a single-click interaction -- not configure-and-confirm. In practice, "Add field" then looks like this on small-screen: ...and like this on large-screen: |
Ok. In principle that makes sense. However the dynamic height of modals relies on having a |
If conditional use of the I've ensured the If you'd like, @rjmackay, I can create an issue dedicated to the task of implementing support in the client. On the other hand, I can see this issue essentially serving that purpose -- that fixing the issue you've raised is accomplished by building support for |
@middle8media if you could flag where we need to replace modals with mainsheet patterns, I can update in the client. or given @ryanchristo already built the pattern maybe you could just swap the functions on the client |
In most cases this is added so that modal content can be scrolled above the
modal-actions
div, but when there is no modal-actions div the padding is still present.The text was updated successfully, but these errors were encountered: