Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large blank space at the bottom of modals #85

Closed
rjmackay opened this issue Oct 4, 2016 · 4 comments
Closed

Large blank space at the bottom of modals #85

rjmackay opened this issue Oct 4, 2016 · 4 comments
Assignees
Labels

Comments

@rjmackay
Copy link
Contributor

rjmackay commented Oct 4, 2016

screenshot 2016-10-05 12 45 42

In most cases this is added so that modal content can be scrolled above the modal-actions div, but when there is no modal-actions div the padding is still present.

@brandonrosage
Copy link
Contributor

.modal-body and .modal-actions are intended to work in concert. So if you have a modal window with no actions, just refrain from wrapping the "body" in the .modal-body container -- simply don't use that wrapper.

Aside

The upcoming "free-form surveys" solution reinforces the use of the "mainsheet" pattern, which is particularly useful for interactions like "Add field," where there's a single-click interaction -- not configure-and-confirm.

In practice, "Add field" then looks like this on small-screen:

small screen

...and like this on large-screen:

large screen

@rjmackay
Copy link
Contributor Author

.modal-body and .modal-actions are intended to work in concert. So if you have a modal window with no actions, just refrain from wrapping the "body" in the .modal-body container -- simply don't use that wrapper.

Ok. In principle that makes sense. However the dynamic height of modals relies on having a modal-body div. The PL uses the modal-body container, and we do the same in client.

@brandonrosage
Copy link
Contributor

If conditional use of the .modal-body wrapper isn't possible, I'd lobby for supporting the .mainsheet pattern in the client, since it exists primarily to serve as an interstitial window with no window-level actions (like Save or Cancel).

I've ensured the develop branch has the HTML, CSS, and JS necessary to support it.

If you'd like, @rjmackay, I can create an issue dedicated to the task of implementing support in the client. On the other hand, I can see this issue essentially serving that purpose -- that fixing the issue you've raised is accomplished by building support for mainsheet.

@rjmackay
Copy link
Contributor Author

@middle8media if you could flag where we need to replace modals with mainsheet patterns, I can update in the client. or given @ryanchristo already built the pattern maybe you could just swap the functions on the client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants