exclude grafana-4.6.* in tendrl_unit_test_setup.yml #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because tendrl-monitoring-integration depends on "grafana < 4.5.3"
dahorak
changed the title
mkudlej
approved these changes
Jan 9, 2018
fbalak
reviewed
Jan 9, 2018
| - name: "WORKAROUND - exclude=grafana-4.6.*" | ||
| lineinfile: | ||
| path: '/etc/yum.conf' | ||
| line: 'exclude=grafana-4.6.*' |
There was a problem hiding this comment.
Wouldn't it be better to preserve content of exclude variable so it would not break any usage with other playbooks that also set this variable (maybe for future work, we don't have anything like that now)? Maybe something like:
lineinfile:
path: '/etc/yum.conf'
regexp: '^exclude=(.*)'
line: 'exclude=\1 grafana-4.6.*'
backrefs=True
There was a problem hiding this comment.
@fbalak Good point, let me try if it will do what we expect...
There was a problem hiding this comment.
It seems to be not so easy to accomplish this request, so I would keep it in the original shape, as it shouldn't break anything in this particular scenario (it is used on each time freshly installed machine). And still I'm considering it just as a Workaround.
fbalak
approved these changes
Jan 9, 2018
| - name: "WORKAROUND - exclude=grafana-4.6.*" | ||
| lineinfile: | ||
| path: '/etc/yum.conf' | ||
| line: 'exclude=grafana-4.6.*' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because tendrl-monitoring-integration depends on "grafana < 4.5.3"
Fixing issue with preparation of test server for package validation (for example: https://ci.centos.org/view/tendrl-build-release/job/tendrl-pkgval-X-release-prepare/)