split valid_user_data and valid_new_user fixtures by roles #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new fixtures: valid_new_normal_user valid_normal_user_data valid_new_admin_user valid_admin_user_data Roles are defined in: https://redhat.invisionapp.com/share/KNB25OEQT#/screens/226063796 Change of role names: https://github.com/Tendrl/specifications/pull/237/files
|
@mbukatov I have linked it in commit message. |
|
@fbalak Thanks! Do you think it would make sense to add this information into comment or docstring of the fixture? |
|
@mbukatov I wouldn't link design documents directly into docstring but I updated the docstring based on: |
|
@mbukatov Added reference links to docstring. |
dahorak
approved these changes
Mar 8, 2018
|
This needs to be reworked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new fixtures:
valid_new_normal_user
valid_normal_user_data
valid_new_admin_user
valid_admin_user_data
If this PR will be merged I will create an issue that reminds us that there should be created separate test case for admin roles (or maybe create one more fixture to yield users of all roles...).
Roles are defined in:
https://redhat.invisionapp.com/share/KNB25OEQT#/screens/226063796
Change of role names:
https://github.com/Tendrl/specifications/pull/237/files