Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest cli #210

Merged
merged 8 commits into from
Dec 18, 2018
Merged

Pytest cli #210

merged 8 commits into from
Dec 18, 2018

Conversation

fbalak
Copy link
Contributor

@fbalak fbalak commented Nov 8, 2018 •
edited by mbukatov
Loading

This wrapper can be called for example with:

./pytest_cli.py -svvvrx usmqe_tests/api/something/test_something

mbukatov
mbukatov requested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@mbukatov mbukatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting few changes, and we need to update docs as well (section about how to run the tests).

pytest_cli.py Outdated Show resolved Hide resolved
pytest_cli.py Outdated Show resolved Hide resolved
pytest_cli.py Outdated Show resolved Hide resolved
pytest_cli.py Show resolved Hide resolved
pytest_cli.py Outdated Show resolved Hide resolved
@fbalak fbalak requested a review from mbukatov December 17, 2018 09:32
mbukatov
mbukatov approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@mbukatov mbukatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fixes. I'm going to add documentation for this and merge it.

pytest_cli.py
if (not isinstance(params['ansible_playbook_inventory'], str)
and isinstance(params['ansible_playbook_inventory'], Iterable)):
params['ansible_playbook_inventory'] = params[
'ansible_playbook_inventory'][0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would crash if the inventory variable is an empty list :)

ebondare
ebondare reviewed Dec 18, 2018
View reviewed changes
docs/test_execution.rst Outdated Show resolved Hide resolved
@mbukatov mbukatov self-assigned this Dec 18, 2018
ebondare
ebondare reviewed Dec 18, 2018
View reviewed changes
docs/test_execution.rst Outdated Show resolved Hide resolved
ebondare
ebondare reviewed Dec 18, 2018
View reviewed changes
docs/test_execution.rst Outdated Show resolved Hide resolved
ebondare
ebondare reviewed Dec 18, 2018
View reviewed changes
docs/test_execution.rst Outdated Show resolved Hide resolved
@mbukatov mbukatov merged commit 0b04c17 into usmqe:master Dec 18, 2018
@mbukatov mbukatov mentioned this pull request Dec 18, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebondare ebondare ebondare left review comments

@mbukatov mbukatov mbukatov approved these changes

@dahorak dahorak Awaiting requested review from dahorak

Assignees

@mbukatov mbukatov

@fbalak fbalak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbalak @mbukatov @ebondare