Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing column for ptlen in Section 2.3 of Symmetric Sub-spec #100

Closed
hbooth opened this issue Mar 28, 2017 · 11 comments
Closed

Missing column for ptlen in Section 2.3 of Symmetric Sub-spec #100

hbooth opened this issue Mar 28, 2017 · 11 comments
Labels

Comments

@hbooth
Copy link
Collaborator

hbooth commented Mar 28, 2017

In Section 2.2 of the Symmetric sub-spec, the table contains a row for ptlen that references Section 2.3. This information appears to be missing from Section 2.3.

@hbooth hbooth added the Bug label Mar 28, 2017
@Kritner
Copy link
Contributor

Kritner commented Mar 28, 2017

At one point could table 2.3 have referenced the Column Payload as Payload/PT length ? If it wasn't there, I know I have seen the two used interchangeably elsewhere - though it may have been CAVS itself, not the spec, I don't recall.

@hbooth
Copy link
Collaborator Author

hbooth commented Mar 28, 2017

Ok, I see what you are saying. I was just scanning for PT and missed Payload. Maybe consistent terminology would be beneficial?

@atvassilev
Copy link
Collaborator

I looked at the table in Section 2.2 and think that one cosmetic change may be helpful: increase the width of the first and second columns a bit at the expense of the last column. This could resolve the issue with chopping off keyingOption at the last letter and similarly for Prerequisite. xml2rfc allows manipulating the relative width of columns like:

Column1
Column2
Column3
Column4
Column5

I am not sure these numbers are the best but one could start with them.

@atvassilev
Copy link
Collaborator

Oops, it looks like the web edit interface stripped off all of my xml. Bummer, does anyone know how to work around this?

@celic
Copy link
Collaborator

celic commented Mar 28, 2017

Try placing your code inside back ticks `

This uses the "code" interface to make it look like...

<table>Column1</table>

@atvassilev
Copy link
Collaborator

@celic thanks.

Here is what I meant to provide as example:
'Column1'
'Column2'
'Column3'
'Column4'
'Column5'

@atvassilev
Copy link
Collaborator

Wow, still no luck...

@celic
Copy link
Collaborator

celic commented Mar 28, 2017

Sorry, it is a back tick. Same button as ~ but without holding shift. It is a rather obscure character on a keyboard.

@atvassilev
Copy link
Collaborator

Ah OK,

<ttcol align="left" width="23%">Column1</ttcol>
<ttcol align="left" width="22%">Column2</ttcol>
<ttcol align="left" width="20%">Column2</ttcol>
<ttcol align="left" width="20%">Column2</ttcol>
<ttcol align="left" width="15%">Column2</ttcol>

Again these are just suggested numbers not necessarily the solution.

@bfussell
Copy link
Collaborator

I'll be happy to change payload to ptLen in the table 2.3, but I'm failing to see and issue with table 2.2 sizing. KeyingOption fits perfectly when displayed with Chrome.

atvassilev added a commit that referenced this issue Apr 4, 2017
ptLen update for #100 and acvp-client removal #106
@atvassilev
Copy link
Collaborator

Resolved with PR #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants