For benchmark 8 #699
Merged
For benchmark 8 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyer
force-pushed
the
for_benchmark_8
branch
2 times, most recently
from
c970eb3
to
92f16f0
Compare
wd15
reviewed
Jan 27, 2020
|
Looks fine, but I don't think that an intermediate CellVariable is needed. |
wd15
approved these changes
Jan 27, 2020
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jan 27, 2020
Contrary to documentation, `conda remove` removes all packages that fipy *depends on*. `--force` is supposed to be about "removal of a package without removing packages that depend on it", but it all appears to work bass-ackwards.
guyer
force-pushed
the
for_benchmark_8
branch
from
5106f41
to
2588c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted patches to get phase field benchmark 8 working.