Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map confusion #206

Closed
danielskatz opened this issue Apr 22, 2020 · 5 comments · Fixed by #208
Closed

map confusion #206

danielskatz opened this issue Apr 22, 2020 · 5 comments · Fixed by #208
Assignees

Comments

@danielskatz
Copy link
Contributor

I'm confused that the link from the main site under RSE Map goes to https://us-rse.org/map/, and there is also https://us-rse.org/usrse-map/ which doesn't seem to have any way to get to from the main site.

Also as a side note, there's a dot in Pasadena, Newfoundland, Canada that should be in Pasadena, CA, USA

@vsoch
Copy link
Member

vsoch commented Apr 22, 2020

There is a usrse-map repository, which is programatically parsed based on locations in people that sign up. https://github.com/USRSE/usrse-map I created this after the original map (which was sort of opt in) and they are different! @cosden and I were talking about removing the /map/ and just directing to usrse-map, but he said it's not urgent / priority since there are a lot of things on his place. Does that clear up the confusion?

The Pasadena parsing was my choosing for the location - I'll take a look and see if it needs to be fixed up.

@cosden
Copy link
Member

cosden commented Apr 22, 2020

Yes I think we should swap about the main site map with the usrse-map. We talked about it a week or two ago and I didn't have time, so I put it on my back burner. This is good - I should have opened an issue.

@vsoch
Copy link
Member

vsoch commented Apr 22, 2020

Yep! Should be fairly easy to do, you could just change the url actually and leave the current map page existing (but hidden) in case we want to use it again. Or just delete everything and I'll be sad but get over it.

@vsoch vsoch self-assigned this Apr 22, 2020
@vsoch
Copy link
Member

vsoch commented Apr 22, 2020

I'll fix this up, PR shortly.

@vsoch
Copy link
Member

vsoch commented Apr 22, 2020

The PR #208 is opened and ready for review to update the map linked here to be the larger one. The pasadena issue is also fixed.

Before:

image

After:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants