Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OR-40 and OR-WFHDC Form Models and React pages #1216

Draft
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

mrbluesky2
Copy link
Contributor

What kind of change does this PR introduce? (delete not applicable)

  • Feature
  • OR-40 Income Tax and OR-WFHDC Forms are implemented for users who select Oregon as their state of residence.
  • Form Model, Redux logic, State Questions React page for Oregon state income forms

richmoni and others added 30 commits January 16, 2022 14:41
Create base versions of form models for Form OR-40, Schedule OR-WFHDC, and Form OR-40-V. Create Parameters file. Add associated PDFs to the public/forms directory.

Co-authored-by: Kyle.Bonner <KyleBonner@users.noreply.github.com>
Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com>
Co-authored-by: AnthonyTrinh8 <AnthonyTrinh8@users.noreply.github.com>
Implement Base Form Models for Form OR-40-N/OR-40-P and Schedule OR-ASC/OR-ASC-NP
Co-authored-by: bonnerky <bonnerky@users.noreply.github.com>
Co-authored-by: Isamu Richmond <richmoni@oregonstate.edu>
Co-authored-by: AnthonyTrinh8 <AnthonyTrinh8@users.noreply.github.com>
Fix ESLint warnings in 2021 OR form models
2021 Schedule OR-WFHDC React form fields
…ng state-specific question responses

Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com>
Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com>
Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #1216 (403ce6a) into master (f32c7c0) will decrease coverage by 1.51%.
The diff coverage is 2.16%.

@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
- Coverage   53.81%   52.30%   -1.52%     
==========================================
  Files         235      238       +3     
  Lines       11364    11801     +437     
  Branches     1512     1676     +164     
==========================================
+ Hits         6116     6172      +56     
- Misses       5233     5613     +380     
- Partials       15       16       +1     
Impacted Files Coverage Δ
src/components/Menu.tsx 95.83% <ø> (ø)
src/components/stateForms/OR/ORWFHDC.tsx 0.00% <0.00%> (ø)
src/core/pdfFiller/fillPdf.ts 48.64% <0.00%> (-5.90%) ⬇️
src/data/urls.ts 100.00% <ø> (ø)
src/forms/Y2021/stateForms/OR/OR40.ts 0.15% <0.00%> (+0.15%) ⬆️
src/forms/Y2021/stateForms/OR/Parameters.ts 100.00% <ø> (+100.00%) ⬆️
src/forms/Y2021/stateForms/index.ts 100.00% <ø> (ø)
src/redux/reducer.ts 34.05% <0.00%> (-0.38%) ⬇️
src/components/StateQuestions.tsx 7.14% <7.14%> (ø)
src/core/data/stateQuestions.ts 18.75% <18.75%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32c7c0...403ce6a. Read the comment docs.

Copy link
Collaborator

@thegrims thegrims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I navigate to the state page without filling in primary taxpayer information, the below error is thrown

Cannot read properties of undefined (reading 'state')

@thegrims
Copy link
Collaborator

screenshot

Browser metadata
Path:      /statequestions
Browser:   Chrome 101.0.4951.54 on Windows 10
Viewport:  1536 x 754 @1.25x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Copy link
Collaborator

@thegrims thegrims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the dropdown text is clipping off the page, can a newline be added to the longer dropdown options to keep the text in the state questions container?

@thegrims
Copy link
Collaborator

I think all the 'enter amount here' fields should use LabeledInput with the currency patternConfig. That will add some nice features like only allowing numbers, adding currency formatting, ect. All of those fields should have a label with the form field and description like boxLabel('4b', 'Guaranteed payments for capital')

<LabeledInput
         label={boxLabel('4b', 'Guaranteed payments for capital')}
         patternConfig={Patterns.currency}
         name="guaranteedPaymentsForCapital"
       />

@thegrims
Copy link
Collaborator

image

This information should be availible under Y2021.w2s[SOME_W2_INDEX].stateWithholding if w2s are filled out, then all statewithholdings from all w2s should be summed and used instead of this form field input.

@thegrims
Copy link
Collaborator

thegrims commented May 28, 2022

image
This question should only show up if the user meets the AGI criteria

@thegrims
Copy link
Collaborator

image
This question should either be a removed or a checkbox for the primary taxpayer and the spouse if one exists for $3 each

@thegrims
Copy link
Collaborator

image
We shouldn't require a user to always select an option in this dropdown since they don't always underpay on their taxes. If we need to we can remove this field

@thegrims
Copy link
Collaborator

When Create OR Return is selected, the dependant date of birth is read even if a dependant doesn't exist

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'dateOfBirth')
    at n.r.Dependent1DateOfBirth (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:1973275)
    at n.r.f25 (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:1973409)
    at n.r.fields (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:1996926)
    at n.renderedFields (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:1707231)
    at 2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:2004313
    at l (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:1131736)
    at Generator._invoke (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:1131524)
    at Generator.next (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:1132161)
    at r (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:345066)
    at u (2bda5071758dd5d21aba7f1a0b9ff4b65b3795b3.js:1:345268)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants