-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OR-40 and OR-WFHDC Form Models and React pages #1216
base: master
Are you sure you want to change the base?
OR-40 and OR-WFHDC Form Models and React pages #1216
Conversation
Create base versions of form models for Form OR-40, Schedule OR-WFHDC, and Form OR-40-V. Create Parameters file. Add associated PDFs to the public/forms directory. Co-authored-by: Kyle.Bonner <KyleBonner@users.noreply.github.com> Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com> Co-authored-by: AnthonyTrinh8 <AnthonyTrinh8@users.noreply.github.com>
Generate base versions of form models
Implement Base Form Models for Form OR-40-N/OR-40-P and Schedule OR-ASC/OR-ASC-NP
Co-authored-by: bonnerky <bonnerky@users.noreply.github.com> Co-authored-by: Isamu Richmond <richmoni@oregonstate.edu> Co-authored-by: AnthonyTrinh8 <AnthonyTrinh8@users.noreply.github.com>
Fix ESLint warnings in 2021 OR form models
2021 Schedule OR-WFHDC React form fields
…ng state-specific question responses Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com>
Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com>
Co-authored-by: John Pierre Carr <mrbluesky2@users.noreply.github.com>
…evelopment/UsTaxes into naming-form-model-fields
…evelopment/UsTaxes into naming-form-model-fields
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
- Coverage 53.81% 52.30% -1.52%
==========================================
Files 235 238 +3
Lines 11364 11801 +437
Branches 1512 1676 +164
==========================================
+ Hits 6116 6172 +56
- Misses 5233 5613 +380
- Partials 15 16 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I navigate to the state page without filling in primary taxpayer information, the below error is thrown
Cannot read properties of undefined (reading 'state')
…nt/UsTaxes into naming-form-model-fields
Browser metadata
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the dropdown text is clipping off the page, can a newline be added to the longer dropdown options to keep the text in the state questions container?
I think all the 'enter amount here' fields should use LabeledInput with the currency patternConfig. That will add some nice features like only allowing numbers, adding currency formatting, ect. All of those fields should have a label with the form field and description like
|
When
|
What kind of change does this PR introduce? (delete not applicable)