Add react helmet and titles #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluSCALE4
force-pushed
the
update-titles
branch
from
4b453a6
to
e6c3e75
Compare
bluSCALE4
force-pushed
the
update-titles
branch
from
e6c3e75
to
99eec27
Compare
thegrims
approved these changes
Sep 8, 2021
bluSCALE4
force-pushed
the
update-titles
branch
from
1168768
to
a57c686
Compare
…mpt component to prevent data loss
bluSCALE4
force-pushed
the
update-titles
branch
from
a57c686
to
2fcd6a7
Compare
thegrims
requested changes
Sep 9, 2021
| <FormProvider {...methods}> | ||
| <form tabIndex={-1} onSubmit={handleSubmit(onAdvance)}> | ||
| <Helmet> | ||
| <title>1098-E Information | Deductions | UsTaxes.org</title> |
There was a problem hiding this comment.
Would it be better for all these titles to be in one place in the Main component
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 69.25% 71.27% +2.01%
==========================================
Files 114 116 +2
Lines 3786 3815 +29
Branches 587 595 +8
==========================================
+ Hits 2622 2719 +97
+ Misses 1150 1082 -68
Partials 14 14
Continue to review full report at Codecov.
|
thegrims
approved these changes
Dec 9, 2021
zakpatterson
pushed a commit
that referenced
this pull request
Dec 18, 2021
* Add react helmet and titles * Move focus to fields when adding records * Add auto focus; Add sub form onSave and handleSubmit trigger; Add Prompt component to prevent data loss * Fix issues with Prompt * Remove preventDefault preventing advancing to next page * add router wrapper to test component * removing default value from W2JobInfo * removing autofocus that was causing tests to fail Co-authored-by: Aidan Grimshaw <grimshawaidan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pages so titles are updated on transitions.