Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-if #608

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Remove react-if #608

merged 1 commit into from
Oct 5, 2021

Conversation

zakpatterson
Copy link
Collaborator

@zakpatterson zakpatterson commented Oct 4, 2021

Frustrations caused by react-if in #605, #606, #607 make me want to remove react-if. If react-if doesn't see the correct DOM structure at runtime, then it throws out console warnings and has undefined behavior. So we can fix that at compile time, and we don't need react-if.

@zakpatterson zakpatterson changed the title Fix missed update change for react-if Remove react-if Oct 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #608 (99f3a9e) into master (8483a8a) will decrease coverage by 0.02%.
The diff coverage is 48.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   63.83%   63.80%   -0.03%     
==========================================
  Files         108      108              
  Lines        3644     3666      +22     
  Branches      552      560       +8     
==========================================
+ Hits         2326     2339      +13     
- Misses       1303     1312       +9     
  Partials       15       15              
Impacted Files Coverage Δ
src/components/TaxPayer/PersonFields.tsx 16.66% <0.00%> (-3.34%) ⬇️
src/components/createPDF.tsx 3.33% <0.00%> (-0.24%) ⬇️
src/components/income/RealEstate.tsx 8.06% <0.00%> (-0.42%) ⬇️
src/components/income/W2JobInfo.tsx 7.14% <0.00%> (-0.55%) ⬇️
src/components/FormContainer.tsx 94.59% <100.00%> (+0.30%) ⬆️
src/components/Questions.tsx 95.83% <100.00%> (+0.83%) ⬆️
src/components/TaxPayer/Address.tsx 92.85% <100.00%> (+1.94%) ⬆️
src/irsForms/ScheduleEIC.ts 80.44% <0.00%> (ø)
src/irsForms/F1040.ts 78.09% <0.00%> (+0.47%) ⬆️
src/irsForms/worksheets/ChildTaxCreditWorksheet.ts 100.00% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796b759...99f3a9e. Read the comment docs.

@thegrims thegrims merged commit 18da910 into ustaxes:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants