Health Savings accounts (Form 8889) #678

ctSkennerton · 2021-10-23T03:52:12Z

This is the beginning of my work to implement health savings accounts. Feedback much appreciated. Fixes #205.

Tasks:

Add stub of Form 8889
Link in Form 8889 to schedule 1 and schedule 2
Add in information from W2 box 12 to UI, which tracks employer contributions. (Help appreciated here. I'm not good with react and don't know how to add in this line - it needs to be a list of box 12 entries)
Write in logic to determine the max contribution amount
Write HSA UI which needs input on which months each HSA was active for. (Perhaps react-month-picker could be used)
wire up the PDF filing as a separate form 8889 needs to be filled out for each spouse (if they are filing jointly and each have one)
Write some tests.

What kind of change does this PR introduce?

Feature

Form 8853 is for reporting Archer MSA accounts and are used to calculate results in form 8889.

zakpatterson · 2021-10-23T04:47:38Z

This is awesome.

Briefly reviewing the requirements for W-2 box 12, it looks like there are a bunch of possible codes, and it is possible to have more than one code for that box.

ctSkennerton · 2021-10-23T04:54:26Z

Briefly reviewing the requirements for W-2 box 12, it looks like there are a bunch of possible codes, and it is possible to have more than one code for that box.

Yes box 12 can have multiple lines each with a different code and amount. some are just informational but others can be used in different schedules. In some W2 they are actually labeled as 12a, 12b, 12c, 12d but I don't think that is significant, it's just to show that there are multiple items.

Rewrites some of the W2 data model to handle box 12 as a dictionary instead of an array. A single W2 should only have one value for each Box 12 code

zakpatterson · 2021-10-24T01:34:18Z

I fixed up some compile errors, and implemented UI for Box 12. See here: ctSkennerton#1. Merging this PR on your fork will incorporate those commits directly here.

F8889 add react box 12

# Conflicts: # src/irsForms/F1040.ts # src/irsForms/Schedule2.ts # src/tests/components/income/W2JobInfo.test.tsx

codecov-commenter · 2021-10-24T11:22:28Z

Codecov Report

Merging #678 (3f2ffe5) into master (752e48b) will increase coverage by 0.05%.
The diff coverage is 73.08%.

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   70.59%   70.64%   +0.05%     
==========================================
  Files         195      201       +6     
  Lines        6165     6555     +390     
  Branches     1004     1103      +99     
==========================================
+ Hits         4352     4631     +279     
- Misses       1799     1910     +111     
  Partials       14       14

Impacted Files	Coverage Δ
src/components/GettingStarted.tsx	`37.50% <ø> (ø)`
src/components/Menu.tsx	`93.33% <ø> (ø)`
src/components/input/DatePicker.tsx	`0.00% <0.00%> (ø)`
src/components/input/index.ts	`100.00% <ø> (ø)`
src/data/urls.ts	`100.00% <ø> (ø)`
src/forms/Y2020/irsForms/F8853.ts	`0.00% <0.00%> (ø)`
src/forms/Y2021/irsForms/F8853.ts	`0.00% <0.00%> (ø)`
src/forms/tests/CommonTests.ts	`90.62% <ø> (-1.05%)`	⬇️
src/forms/tests/TestKit.ts	`34.92% <0.00%> (-1.15%)`	⬇️
src/redux/data.ts	`100.00% <ø> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752e48b...3f2ffe5. Read the comment docs.

zakpatterson · 2021-10-24T11:27:01Z

Fixed up merge and tests issues again. I'll work on other issues for a bit, but feel free to call me back if you need anything.

- Add menu items for HSA - Add in HSA input form - Add in Date Picker input component using @material-ui/pickers so that a user can select their coverage start and end dates - Add in Redux state actions to add, edit, and remove HSA form entries

ctSkennerton · 2021-10-31T06:18:01Z

@zakpatterson hope I can get your help again...

I'm running into an error when trying to implement the UI for adding HSAs. I've tried to implement a frontend form with a date picker (still a work in progress) but when I go to save a new HSA entry I get the following error:

Unhandled Rejection (TypeError): validate is not a function. (In 'validate(data)', 'validate' is undefined)
checkType
src/redux/validate.ts:9

Googling hasn't given me any insights into what that might be. Have you experienced this error before and know what the cause might be?

src/redux/validate.ts

Fix negative value

F8889 review - fix negative values

Due to adding HSA distributions, we can no longer assume that total tax is less than taxable income. But we can still assume that the tax on taxable income (L16 tax on L15 income) is less than taxable income. And we can also assume that total tax must be less than AGI.

# Conflicts: # src/components/income/W2JobInfo.tsx

Equal condition needs to match tolerance of form rounding to nearest dollar

Many schedules can be duplicated

For total income >= 0, AGI <= total income Total Tax <= total income Total income can be negative, that's the only case where tax is greater than total income. Total tax can be greater than AGI. Adjustments to income can be subtracted from taxable income but at the same time cause additional tax.

zakpatterson · 2022-01-03T23:55:41Z

I had total tax must be less than AGI. This is not true, it is possible to have subtractions to total income which are still taxable in other ways. As long as total income is positive, we only know that total income >= AGI and total income >= total tax. Total tax can be more or less than AGI.

zakpatterson · 2022-01-03T23:57:13Z

I think this is ready with respect to calculations and tests. @thegrims when you can please review for UI and merge thanks!

thegrims · 2022-01-08T05:49:00Z

The date picker should either load empty or start in the current tax year. I think loading empty would be the best

ctSkennerton · 2022-01-09T01:08:17Z

@thegrims sounds good, done.

thegrims · 2022-01-09T03:38:35Z

src/components/savingsAccounts/healthSavingsAccounts.tsx

+  // return (
+  //   <form tabIndex={-1} onSubmit={onAdvance}>
+  //     <h2>Health Savings Accounts (HSA)</h2>
+  //     {/* <p>
+  //       did you already make payments towards your {CURRENT_YEAR} taxes this
+  //       year or last year?
+  //     </p> */}
+  //     <FormProvider {...methods}>{form}</FormProvider>
+  //     {navButtons}
+  //   </form>
+  // )


This commented block of code should be removed if it isn't being used

thegrims · 2022-01-09T03:42:12Z

Looks good, only other comment is on removing the commented line of code quoted above. Thanks for your contribution!

ctSkennerton added 6 commits October 12, 2021 00:12

add in form 8889 stub

7160883

Add in references to form 8889 in Schedule 1 and Schedule 2

0ddc67c

Add in stub form 8853.

4813972

Form 8853 is for reporting Archer MSA accounts and are used to calculate results in form 8889.

Fix Schedule 2 line 8 strings.

63b98d2

Add in information about W2 Box 12 and HSAs to the data model.

03f1a86

Start adding in calculations for form 8889

5b50d83

zakpatterson added 2 commits October 24, 2021 08:40

Fix compile errors

0b575da

Implement W2 Box 12 UI

902c71a

Rewrites some of the W2 data model to handle box 12 as a dictionary instead of an array. A single W2 should only have one value for each Box 12 code

ctSkennerton and others added 4 commits October 23, 2021 22:41

Merge pull request #1 from zakpatterson/f8889-add-react-box-12

4d45ce4

F8889 add react box 12

Merge master

2310228

Fix testing regression

e05d1fe

Merge branch 'master' into f8889-review

e53a8d9

# Conflicts: # src/irsForms/F1040.ts # src/irsForms/Schedule2.ts # src/tests/components/income/W2JobInfo.test.tsx

ctSkennerton added 2 commits October 30, 2021 23:04

Add in Health Savings Account UI.

324a292

- Add menu items for HSA - Add in HSA input form - Add in Date Picker input component using @material-ui/pickers so that a user can select their coverage start and end dates - Add in Redux state actions to add, edit, and remove HSA form entries

lint

409c7ca

zakpatterson reviewed Oct 31, 2021

View reviewed changes

src/redux/validate.ts Outdated Show resolved Hide resolved

ctSkennerton added 9 commits October 31, 2021 18:49

Fix typo in validation of HSAs

7141ba0

Add in the coverage type and coverage span to HSA info.

72eee0c

Remove commented out code in the DatePicker component

ed52abf

Add in functions for calculating the contribution limit.

d78cd9f

Add in form 8889 test file

edf59da

Filter the HSAs so that only the relevant ones are used.

eef5936

Add in logic and tests for partial year HSAs

2392188

Add in distribution fields to HSA object

59c354a

Add in new logic to determine the correct contribution limits

ddf0164

ctSkennerton marked this pull request as ready for review January 2, 2022 08:03

ctSkennerton changed the title ~~Start implementation for Health Savings accounts (Form 8889)~~ Health Savings accounts (Form 8889) Jan 2, 2022

zakpatterson and others added 14 commits January 2, 2022 11:06

Improve error log directory name

3ede485

Uncomment 2020 f1040 test, showing negative value

8bea48d

Fix negative value

Uncomment 2021 test, fix negative value error

c4c53ac

Update TestKit.ts

ce02a2b

Merge pull request #3 from zakpatterson/f8889-review

709d1f7

F8889 review - fix negative values

Give createpdf test more time

d6b26ac

Give some tests more time

a097155

Merge branch 'master' into f8889-review

0ace88e

# Conflicts: # src/components/income/W2JobInfo.tsx

Merge branch 'f8889-review' into f8889

7a15c9e

Fix missing properties in test data

2a6a346

Fix lessThanOrEqualComparison

d880f5b

Equal condition needs to match tolerance of form rounding to nearest dollar

Remove commented out test

75e1894

Many schedules can be duplicated

Merge branch 'master' into f8889

b98c580

zakpatterson force-pushed the f8889 branch from 8562866 to b98c580 Compare January 5, 2022 00:42

ctSkennerton added 3 commits January 8, 2022 16:02

Add in forms to the getting started page

e316830

Set the default value in the date picker to be blank

531ccbc

Merge branch 'f8889' of github.com:ctSkennerton/UsTaxes into f8889

fe99ce2

thegrims reviewed Jan 9, 2022

View reviewed changes

thegrims approved these changes Jan 9, 2022

View reviewed changes

remove commented code in healthSavingsAccount.tsx

3f2ffe5

thegrims merged commit d37fcf9 into ustaxes:master Jan 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Health Savings accounts (Form 8889) #678

Health Savings accounts (Form 8889) #678

ctSkennerton commented Oct 23, 2021 •

edited

Loading

zakpatterson commented Oct 23, 2021

ctSkennerton commented Oct 23, 2021

zakpatterson commented Oct 24, 2021 •

edited

Loading

codecov-commenter commented Oct 24, 2021 •

edited by codecov bot

Loading

zakpatterson commented Oct 24, 2021

ctSkennerton commented Oct 31, 2021

zakpatterson commented Jan 3, 2022

zakpatterson commented Jan 3, 2022

thegrims commented Jan 8, 2022

ctSkennerton commented Jan 9, 2022

thegrims Jan 9, 2022

thegrims commented Jan 9, 2022

Health Savings accounts (Form 8889) #678

Health Savings accounts (Form 8889) #678

Conversation

ctSkennerton commented Oct 23, 2021 • edited Loading

zakpatterson commented Oct 23, 2021

ctSkennerton commented Oct 23, 2021

zakpatterson commented Oct 24, 2021 • edited Loading

codecov-commenter commented Oct 24, 2021 • edited by codecov bot Loading

Codecov Report

zakpatterson commented Oct 24, 2021

ctSkennerton commented Oct 31, 2021

zakpatterson commented Jan 3, 2022

zakpatterson commented Jan 3, 2022

thegrims commented Jan 8, 2022

ctSkennerton commented Jan 9, 2022

thegrims Jan 9, 2022

Choose a reason for hiding this comment

thegrims commented Jan 9, 2022

ctSkennerton commented Oct 23, 2021 •

edited

Loading

zakpatterson commented Oct 24, 2021 •

edited

Loading

codecov-commenter commented Oct 24, 2021 •

edited by codecov bot

Loading