Fix floating point errors in PDFs #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A file downloader implementation is going to vary between desktop, web, and test implementations. So I've refactored components that include downloading a PDF to allow this dependency to be injected.
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 65.51% 69.94% +4.43%
==========================================
Files 112 113 +1
Lines 3744 3767 +23
Branches 581 584 +3
==========================================
+ Hits 2453 2635 +182
+ Misses 1278 1118 -160
- Partials 13 14 +1
Continue to review full report at Codecov.
|
Produces failed test:
Shrunk 0 time(s)
Got error: Error: expect(received).toHaveLength(expected)
Expected length: 0
Received length: 1
Received array: [["2020 Schedule 8812 (Form 1040)", [[13, ["topmostSubform[0].Page1[0].f1_12[0]", "2946387.6"]]]]]
Stack trace: Error: expect(received).toHaveLength(expected)
Expected length: 0
Received length: 1
Received array: [["2020 Schedule 8812 (Form 1040)", [[13, ["topmostSubform[0].Page1[0].f1_12[0]", "2946387.6"]]]]]
87 | await fc.assert(
88 | fc.asyncProperty(arbitraries.information, async (info) => {
> 89 | expect(await testEveryField(info, findBadDecimalFormat)).toHaveLength(0)
| ^
90 | }),
91 | {
92 | interruptAfterTimeLimit: 100 * 1000 // 100 seconds
at src/tests/pdfFiller/pdfHandler.test.ts:89:66
at AsyncProperty.run (node_modules/fast-check/lib/check/property/AsyncProperty.generic.js:41:28)
at asyncRunIt (node_modules/fast-check/lib/check/runner/Runner.js:24:21)
at Object.<anonymous> (src/tests/pdfFiller/pdfHandler.test.ts:87:5)
Hint: Enable verbose mode in order to have the list of all failing values encountered during the run
at asyncThrowIfFailed (node_modules/fast-check/lib/check/runner/utils/RunDetailsFormatter.js:133:11)
Fix comment
Either two decimal places or zero Refactor states forms, same numeric implementation
zakpatterson
force-pushed
the
fix-floating-point-errors
branch
from
59c124b
to
9e36050
Compare
zakpatterson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (delete not applicable)
Rounding formatting errors are present in PDF fields with numeric values.
.30000000004style errors as well as string formatting such as123.6are also present.This also refactors things somewhat so we can provide a different downloader in testing. This will also be useful in #686 where pdfs are downloaded from ustaxes.org instead of from the testing machine file system.
See 611de2a for output from failing test.