Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not required values 701 #826

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

zakpatterson
Copy link
Collaborator

Fixes #701

I tried for far too long to get a failing test that would detect NaN showing up in the dispatched action or in the state, but failed. I'll have to revisit that.

What kind of change does this PR introduce? (delete not applicable)

  • Bugfix

Error was printing as [object object]
* Allow cents
* Fix NaN showing up in actions and state
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #826 (98c150f) into master (88bf134) will increase coverage by 0.08%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   70.57%   70.65%   +0.08%     
==========================================
  Files         194      195       +1     
  Lines        6158     6165       +7     
  Branches     1010     1004       -6     
==========================================
+ Hits         4346     4356      +10     
+ Misses       1797     1795       -2     
+ Partials       15       14       -1     
Impacted Files Coverage Δ
src/components/income/W2JobInfo.tsx 100.00% <ø> (ø)
src/core/util.ts 80.24% <72.72%> (-1.19%) ⬇️
src/core/data/validate.ts 100.00% <100.00%> (ø)
src/components/Summary.tsx 51.51% <0.00%> (-4.05%) ⬇️
src/redux/store.ts 73.33% <0.00%> (ø)
src/redux/data.ts 100.00% <0.00%> (ø)
src/forms/Y2020/irsForms/ScheduleEIC.ts 81.00% <0.00%> (+0.55%) ⬆️
src/forms/Y2021/irsForms/ScheduleEIC.ts 81.00% <0.00%> (+1.67%) ⬆️
src/redux/yearDispatch.ts 100.00% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88bf134...98c150f. Read the comment docs.

@thegrims
Copy link
Collaborator

thegrims commented Jan 2, 2022

image
stateWages are still allowed to be undefined

@zakpatterson
Copy link
Collaborator Author

zakpatterson commented Jan 2, 2022

stateWages are still allowed to be undefined

Initially I thought this was ok, because W-2s received for non-filing state residents might be blank in this section? But someone that moved during the year might have a certain amount attributed to each state. So really the state wages /withholding info needs to be in an array here, and this has to do with handling split residency / multiple state returns.

But it does seem like the state wages fields should always be filled in any case, so I'll make those fields required.

@thegrims thegrims merged commit 7056ea3 into ustaxes:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not required values in form being pushed to state
2 participants