Simplify global state data type #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a minor simplification we don't need === undefined checks in several places.
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
- Coverage 70.57% 70.51% -0.06%
==========================================
Files 194 195 +1
Lines 6158 6153 -5
Branches 1010 1002 -8
==========================================
- Hits 4346 4339 -7
- Misses 1797 1800 +3
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a minor simplification we don't need === undefined checks in
several places.
This is a follow-on to #778, also removes some mistaken commented code
What kind of change does this PR introduce? (delete not applicable)