-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automerge dependabot minor #836
Conversation
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 70.72% 69.44% -1.29%
==========================================
Files 201 201
Lines 6555 6555
Branches 1103 1103
==========================================
- Hits 4636 4552 -84
- Misses 1905 1989 +84
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we find a way to conditionally merge this depending on passing the lint and test workflows? For example if prettier/eslint/eslint-plugins have a version update that changes a parsing rule, then we would want that PR to not be merged so we can amend it manually?
with: | ||
github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
- name: Enable auto-merge for Dependabot PRs | ||
if: ${{contains(steps.metadata.outputs.dependency-names, 'my-dependency') && (steps.metadata.outputs.update-type == 'version-update:semver-patch' || steps.metadata.outputs.update-type == 'version-update:semver-minor')}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does my-dependency
come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
Looking around, it seems you can put multiple jobs in a single workflow, and use the |
cd24a22
to
0741d09
Compare
…nd on lint and test actions running successfully
Done! Let me know what you think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What kind of change does this PR introduce? (delete not applicable)