Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automerge dependabot minor #836

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Automerge dependabot minor #836

merged 4 commits into from
Jan 10, 2022

Conversation

thegrims
Copy link
Collaborator

@thegrims thegrims commented Jan 4, 2022

What kind of change does this PR introduce? (delete not applicable)

  • Feature: Auto merge Dependabot minor and patch version PRs to reduce PR approval overhead

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #836 (cadd412) into master (d37fcf9) will decrease coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   70.72%   69.44%   -1.29%     
==========================================
  Files         201      201              
  Lines        6555     6555              
  Branches     1103     1103              
==========================================
- Hits         4636     4552      -84     
- Misses       1905     1989      +84     
  Partials       14       14              
Impacted Files Coverage Δ
src/forms/Y2020/irsForms/ScheduleEIC.ts 55.30% <0.00%> (-25.70%) ⬇️
src/forms/Y2021/irsForms/ScheduleEIC.ts 62.56% <0.00%> (-16.76%) ⬇️
src/core/util.ts 72.83% <0.00%> (-7.41%) ⬇️
src/forms/Y2020/irsForms/Schedule8812.ts 98.11% <0.00%> (-1.89%) ⬇️
src/forms/Y2020/irsForms/F1040.ts 92.85% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37fcf9...cadd412. Read the comment docs.

Copy link
Collaborator

@zakpatterson zakpatterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find a way to conditionally merge this depending on passing the lint and test workflows? For example if prettier/eslint/eslint-plugins have a version update that changes a parsing rule, then we would want that PR to not be merged so we can amend it manually?

with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
- name: Enable auto-merge for Dependabot PRs
if: ${{contains(steps.metadata.outputs.dependency-names, 'my-dependency') && (steps.metadata.outputs.update-type == 'version-update:semver-patch' || steps.metadata.outputs.update-type == 'version-update:semver-minor')}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does my-dependency come from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

@zakpatterson
Copy link
Collaborator

Looking around, it seems you can put multiple jobs in a single workflow, and use the needs keyword on a job to make it depend on other jobs. So maybe we should merge lint, test, build and this merge workflow into a single workflow file?

@thegrims
Copy link
Collaborator Author

Looking around, it seems you can put multiple jobs in a single workflow, and use the needs keyword on a job to make it depend on other jobs. So maybe we should merge lint, test, build and this merge workflow into a single workflow file?

Done! Let me know what you think :)

Copy link
Collaborator

@zakpatterson zakpatterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thegrims thegrims merged commit c174fcc into master Jan 10, 2022
@thegrims thegrims deleted the automerge-dependabot-minor branch January 10, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants