feat: implement SyncTimeout #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knight42
reviewed
Mar 5, 2023
pkg/server/config.go
Outdated
| LogLevel string `mapstructure:"log_level,omitempty" validate:"omitempty,eq=debug|eq=info|eq=warn|eq=error"` | ||
| ListenAddr string `mapstructure:"listen_addr,omitempty" validate:"omitempty,hostport"` | ||
| BindIP string `mapstructure:"bind_ip,omitempty" validate:"omitempty,ip"` | ||
| NamePrefix string `mapstructure:"name_prefix,omitempty" validate:"-"` | ||
| PostSync []string `mapstructure:"post_sync,omitempty" validate:"-"` | ||
| ImagesUpgradeInterval string `mapstructure:"images_upgrade_interval,omitempty" validate:"omitempty,cron"` | ||
| SyncTimeOut int `mapstructure:"sync_timeout,omitempty" validate:"omitempty,gte=0"` |
There was a problem hiding this comment.
这里用 time.Duration 是不是会更好一点，这样配置里可以写 10m, 1h 这种，可读性会好一点
There was a problem hiding this comment.
加了对配置读取和超时的测试，但是感觉新加的 test 代码挺丑的。
There was a problem hiding this comment.
哈哈这可能跟我当初的实现有关，当时写的时候没怎么注意写方便测试的代码。
iBug
force-pushed
the
feature-sync-timeout
branch
from
e32fb01
to
fff846f
Compare
knight42
approved these changes
Mar 6, 2023
| return s, nil | ||
| } | ||
|
|
||
| func TestWaitForSync(t *testing.T) { |
pkg/server/main_test.go
Outdated
| _ = s.c.RemoveRepository(name) | ||
| _ = s.c.RemoveContainer(context.TODO(), prefix+name) | ||
|
|
||
| s.ctx = context.TODO() |
There was a problem hiding this comment.
这里我建议让调用方（具体的 test）传入 context，test 跑完后就能 cancel context，尽量避免 goroutine（下面两行创建的）泄漏
There was a problem hiding this comment.
这里改成了 testcase 开头根据 context.Background() 建一个带 cancel 的 context，然后后面都用这个 ctx。
iBug
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30