Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to get information from kubernetes API instead of downward API and support one namespace per application. #3

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

aztlan2k
Copy link

@aztlan2k aztlan2k commented Apr 4, 2017

@ustudio/dev please review

As we discussed, we need to update the library to support one namespace per application and one cluster per namespace. Because there is no way to get cluster-wide information from the Downward API we need to access it via the Kubernetes API.

Since we were already using the Kubernetes API we removed the dependence on the Downward API and now access all information via the Kubernetes API. This has the added benefit of requiring no special configuration of the pod to use the library.

We decided to store the environment-info secret in the ustudio-system namespace where we were already running the SumoLogic and DataDog integrations.


This change is Reviewable

…I and support one namespace per application.
@fearphage
Copy link
Contributor

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


setup.py, line 14 at r1 (raw file):

setup(name="ustack-logging",
      version="0.2.0",

MINOR: If this is backwards incompatible, it should be a major version bump.


Comments from Reviewable

@aztlan2k
Copy link
Author

aztlan2k commented Apr 4, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion.


setup.py, line 14 at r1 (raw file):

Previously, fearphage (Phred) wrote…

MINOR: If this is backwards incompatible, it should be a major version bump.

"Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable." http://semver.org/#spec-item-4


Comments from Reviewable

@aztlan2k aztlan2k merged commit 7b57cde into master Apr 4, 2017
@aztlan2k aztlan2k deleted the update-for-new-cluster-style branch April 4, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants