Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies to Allow Upgrades #8

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

spiralman
Copy link
Member

This PR updates the versions of the declared dependencies to be more lenient, because neither kubernetes nor datadog use SemVer in their version numbering, which causes the ^ syntax to prevent dependent projects from upgrading those transitive dependencies.

We also added Python 3.12 to the test suite, so we can ensure the library works correctly with that version of Python, and updated the pytest configuration to run with warnings-as-errors.

However, due to the fact that kubernetes depends on python-dateutil which still has not released a version which doesn't generate deprecation warnings at import time in Python 3.12 (see dateutil/dateutil#1314), we had to add an exception to the warnings-as-errors configuration, so that the tests would pass.

@ustudio/reviewers Please review

spiralman and others added 7 commits January 23, 2024 13:04
…-logger, to allow newer versions of those libraries to be installed, since they do not use SemVer.

Co-authored-by: Tim Jensen <tjensen@ustudio.com>
…s correctly in that version of Python.

Co-authored-by: Tim Jensen <tjensen@ustudio.com>
Co-authored-by: Tim Jensen <tjensen@ustudio.com>
…warning from python-dateutil, until they release a new version with the fix: dateutil/dateutil#1314.

Co-authored-by: Tim Jensen <tjensen@ustudio.com>
…library.

Co-authored-by: Tim Jensen <tjensen@ustudio.com>
…library.

Co-authored-by: Tim Jensen <tjensen@ustudio.com>
…ently versioned dependencies.

Co-authored-by: Tim Jensen <tjensen@ustudio.com>
Copy link

@jpham-ustudio jpham-ustudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spiralman spiralman merged commit 31a3c3e into master Jan 23, 2024
4 checks passed
@spiralman spiralman deleted the update-dependencies-to-allow-upgrades branch January 23, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants