USWDS-Site: Fix token pages from audit (Part 4) #2386
Conversation
- No relevant system setting in USWDS
- No relevant uswds setting available
There was a problem hiding this comment.
Important
The u-opacity mixin does not currently exist in USWDS, and it looks like it hasn't for some time. This is likely a bug and is documented in uswds/uswds#5881. Should we remove the reference to it here?
| <tr> | ||
| <th scope="row" data-title="Context"> | ||
| <span class="font-lang-3">setting</span> | ||
| </th> | ||
| <td data-title="Description"> | ||
| <span> | ||
| <a href="{{ site.baseurl }}/design-tokens/opacity/" class="token">opacity</a> | ||
| </span> | ||
| </td> | ||
| <td data-title="Example"> | ||
| <span> | ||
| $theme-hover-opacity: <code>50</code> | ||
| </span> | ||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
Note
I removed some settings examples in this PR because they do not exist in USWDS and I couldn't find an alternative theme setting that accepted these tokens. My goal was to minimize confusion and prevent users from trying to bring a non-existent setting into their config.
Please flag if you feel that removing these examples is too opinionated or would cause more confusion. Also let me know if you find a suitable setting to include here.
| $theme-nav-column-flex: <code>4</code> | ||
| $theme-megamenu-columns: <code>4</code> |
There was a problem hiding this comment.
Not sure if this is a suitable replacement, but was the only setting I could find that was pulled into u-flex. Please let me know if this feels wrong to include here and/or if you have a suitable replacement.
| type: token | ||
| changelogURL: | ||
| items: | ||
| - date: NNNN-NN-NN |
There was a problem hiding this comment.
Important
We need to update changelog dates before merge
There was a problem hiding this comment.
Thanks for these fixes @amyleadem! Updated branch and approved.
Summary
Updated component pages according to the findings reported in the code/developer content audit (Google Docs 🔒)
Note
To keep PR reviews manageable, this PR updates only some of the tokens pages. All other token page updates will be addressed in other PRs.
Important
We need to update changelog dates before merge.
Related issue
Related to #2042
Preview link
Solution
Update code according to the findings in code/developer content audit (Google Docs 🔒).
Please note that all items highlighted yellow in the spreadsheet will be investigated/discussed in the last phase of the component page fixes.
Testing and review