Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Changelog: Add entry for validation & text input #2497

Merged
merged 4 commits into from Mar 1, 2024

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Feb 20, 2024

Summary

Added changelog entries for Validation & Text Input component.

Related issue

Related to uswds/uswds#5233 & #2477.

Preview link

Preview link:

@mejiaj mejiaj marked this pull request as ready for review February 20, 2024 22:27
@amyleadem
Copy link
Contributor

Thinking we should update the component page to say textarea in addition to any references to input. For example, "Connect the input element to your validation checklist" could be "Connect the input or textarea element to your validation checklist". What do you think?

Also wondering if we should show the textarea example in the component preview. I lean away from it because it would probably require re-working the textarea story a bit and I'm not sure how much value it adds. So for now I think it is ok to leave off, but just wanted to bring up the idea in case anyone feels strongly.

@amyleadem amyleadem merged commit 4ce3d63 into release-3.8.0 Mar 1, 2024
2 of 5 checks passed
@mejiaj mejiaj deleted the jm-changelog-validation-text-input branch March 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants