This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address this: #454
Our use case: We have migrated parts of our kubernetes clusters in AWS to graviton (arm) by introducing graviton based
nodegroups. It would be really nice to be able to utilize OCI's multiarch abilities, having the same charts and letting the container daemon choose the appropriate OS architecture build.
IMPORTANT: This PR is mostly a poc to kickstart the conversation to possibly support mutliarch builds, although it does work as it is.
The reason for a discrete Dockerfile is in order to not mess any existing pipeline. The only diff between the two files is:
I am not really comfortable with drone ci, so that's why github actions are utilized here. Moreover, the
docker/setup-qemu-action@v1
,docker/setup-buildx-action@v1
anddocker/setup-buildx-action@v1
seem to do all the complex multiarch work really well.In case github actions are introduced to the upstream repo, there are 4 github repository secrets that are needed:
DOCKER_USERNAME: username used in drone.yml
DOCKER_PASSWORD: password used in drone.yml
DOCKER_REGISTRY: quay.io
DOCKER_ORGANIZATION: uswitch
Just for reference, here is a github action run from my fork: https://github.com/commixon/kiam/actions/runs/657481318 ,
and here is a successful multiarch build