Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase BCT_MAX_BLOCKS #295

Merged
merged 2 commits into from
May 10, 2024
Merged

Increase BCT_MAX_BLOCKS #295

merged 2 commits into from
May 10, 2024

Conversation

Hiro-0110
Copy link
Member

@Hiro-0110 Hiro-0110 commented May 10, 2024

Issue

詳細

詳しくPR内容を記述する

検証結果

ビルドチェック (どちらもチェック)

  • SILSでのビルドチェックに通った(CIで確認)
  • vMicroでのビルドチェックに通った

動作確認チェック (いずれかをチェック)

  • SILSでアルゴリズムが想定通りに動いた
  • 実機でアルゴリズムが想定通りに動いた
  • (テレコマ試験の場合)コマンドファイルを使った試験をパスした

試験結果詳細記述場所 or 詳細ログ保存場所へのリンク

  • 図や表で記述する

補足

何かあれば書く。なければNAとする。

@Hiro-0110 Hiro-0110 self-assigned this May 10, 2024
@Hiro-0110 Hiro-0110 requested review from sksat and a team as code owners May 10, 2024 11:17
@Hiro-0110 Hiro-0110 requested review from 200km, seki-hiro, suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team May 10, 2024 11:17
@conjikidow
Copy link
Member

ありがとうございます。念のため,実機で問題なく動作するか検証お願いします。

@Hiro-0110
Copy link
Member Author

vMicroで書き込んで動きました

@Hiro-0110
Copy link
Member Author

修正後も実機で正しくテレメが降りてくることを確認しました

@Hiro-0110 Hiro-0110 merged commit 137f92a into develop May 10, 2024
9 of 11 checks passed
@Hiro-0110 Hiro-0110 deleted the feature/increase_aobc_bc branch May 10, 2024 14:11
@conjikidow conjikidow added this to the v10.0.0 Major update milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants