Add StoreTelemetry function for hils test #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
approved these changes
Mar 24, 2022
| @@ -149,3 +149,16 @@ int ObcI2cTargetCommunicationBase::GetStoredFrameCounter() { | |||
| if (sim_mode_ != OBC_COM_UART_MODE::HILS) return -1; | |||
| return hils_port_manager_->I2cTargetGetStoredFrameCounter(hils_port_id_); | |||
| } | |||
|
|
|||
| int ObcI2cTargetCommunicationBase::StoreTelemetry( | |||
| const unsigned int stored_frame_num, const unsigned int tlm_size) { | |||
There was a problem hiding this comment.
[NITS] ヘッダと同じような改行のほうが個人的には好みなんですが、そうすると1行あたりが長くなってしまうという感じですか？
There was a problem hiding this comment.
@sksat 一行の制約を100文字くらいにするのはやめたほうが良いですかね？
略語無しで行こうという方針なので、結構長い変数名などが多く、文字数制限にすぐひっかかり逆に読みづらく感じることもあるのですが、、、
There was a problem hiding this comment.
@seki-hiro フォーマットについては別途議論ということで、こちらは一旦マージしてしまって良いです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add StoreTelemetry function for I2C HILS test.
Issue
Details
In order to store some frames of telemetry in the USB-I2C target converter in advance, StoreTelemetry function is added.
Validation results
Link to tests or validation results.
Scope of influence
eg. The behavior of XX will be change.
Supplement
This function may be useful for users when they perform I2C HILS test.
Note
prioritylabel if possible.