Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add laser distance meter and corner cube reflector #77

Merged
merged 14 commits into from
Dec 27, 2023
Merged

Add laser distance meter and corner cube reflector #77

merged 14 commits into from
Dec 27, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Dec 25, 2023 •
edited
Loading

概要

Laser distance meterとcorner cube reflectorの模擬コンポを追加した。

Issue

#3

詳細

次のことを模擬できるLaser distance meterとcorner cube reflectorの模擬コンポを追加した

  • 搭載位置、搭載方向
  • レーザがリフレクタに当たったか、反射したかの判定
  • 複数のリフレクタへの対応

次の部分は未実装

  • ノイズ負荷

検証結果

  • 衛星間重心距離は10mで設定し、レーザー距離計、リフレクタともに向かい合って、重心から50cmの位置に取り付けられているので、計測値は9mとなる。

image

影響範囲

NA

補足

NA

@200km 200km added the priority::medium priority medium label Dec 25, 2023
@200km 200km self-assigned this Dec 25, 2023
TomokiMochizuki
TomokiMochizuki approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@TomokiMochizuki TomokiMochizuki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

アルゴリズムを一通り読ませてもらいましたが、問題なさそうでした。
一点、レーザーが跳ね返ってこなかった場合の挙動に関してINFINITYに変更したほうがいいと思ったのと，reflectorのところで.cppファイルを生成したほうがいいと思ったので、そこだけ修正お願いしたいです。

s2e-ff/data/initialize_files/components/corner_cube_reflector.ini Show resolved Hide resolved
s2e-ff/data/initialize_files/components/corner_cube_reflector.ini Show resolved Hide resolved
s2e-ff/src/components/aocs/corner_cube_reflector.hpp Show resolved Hide resolved
s2e-ff/src/components/aocs/laser_distance_meter.cpp Show resolved Hide resolved
TomokiMochizuki
TomokiMochizuki requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@TomokiMochizuki TomokiMochizuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

間違えてApproveしましたが2点修正お願いします

TomokiMochizuki
TomokiMochizuki approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@TomokiMochizuki TomokiMochizuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approveしました

@200km
Copy link
Member Author

200km commented Dec 27, 2023

Approveしてもらって申し訳ないですが、普通にGetter関数なくて不便そうだったので追加しました。

TomokiMochizuki
TomokiMochizuki approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@TomokiMochizuki TomokiMochizuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getter関数に関しても問題ないと思います。

@200km 200km merged commit edc0223 into develop Dec 27, 2023
8 checks passed
@200km 200km deleted the feature/add-relative-sensor branch December 27, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomokiMochizuki TomokiMochizuki TomokiMochizuki approved these changes

Assignees

@200km 200km

Labels
priority::medium priority medium
Projects
S2E
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@200km @TomokiMochizuki