Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segbot_sensors: missing dependency on depthimage_to_laserscan #20

Closed
jack-oquin opened this issue Sep 19, 2013 · 3 comments
Closed

segbot_sensors: missing dependency on depthimage_to_laserscan #20

jack-oquin opened this issue Sep 19, 2013 · 3 comments
Assignees
Labels

Comments

@jack-oquin
Copy link
Member

I noticed this was missing today when I installed the software on my home development machine using the Installing our code-base on a machine instructions from the wiki.

As a quick fix, I added ros-hydro-depthimage-to-laserscan to the list of APT packages to install.

But, I think a better fix is to add the proper <run-depend> to segbot_sensors.

The best fix is to also add unit test coverage verifying that all packages required by a set of launch files are mentioned as dependencies.

@jack-oquin
Copy link
Member Author

Added the unit tests, but had to comment out this one due to ros-drivers/openni_launch#10:

#roslaunch_add_file_check(launch/kinect)

@jack-oquin
Copy link
Member Author

I checked again, and the fix for ros-drivers/openni_launch#10 has been merged but still not released.

Holding this issue open until we can remove the work-around for that bug.

@jack-oquin
Copy link
Member Author

Closing this issue now that the openni_launch fix has been released and full roslaunch checking is now enabled here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant