Improve code quality - Fix warning level 4 messages (#47) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utilForever
approved these changes
Jan 4, 2018
|
mac os에서 확인하여 Approve 합니다. |
utilForever
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning 수준 4단계에서 빌드가 되도록 수정하였습니다.
Copying elision을 위해 std::move를 제외하였고,
데이터 타입간 호환이 명확해지도록 적절히 타입을 조정하였습니다.
Windows와 Mac OS X에서 빌드를 확인하였습니다.
혹시나 Linux에서 빌드가 안된다거나, 기능상 결함이 발견될 경우 커멘트 부탁드립니다.