Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt GemspecGit cop to new API changes #19

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Conversation

utkarsh2102
Copy link
Owner

@utkarsh2102 utkarsh2102 commented Aug 23, 2020

Adapt GemspecGit cop With the introduction of new API.
cf: https://docs.rubocop.org/rubocop/0.87/v1_upgrade_notes.html

Please note that this still works great and alright, but with time, (perhaps with v1 of RuboCop), it'll not.
So I am doing this ahead of time; take this as a minor refactor.

@terceiro terceiro merged commit 52193f7 into master Aug 23, 2020
@terceiro terceiro deleted the v1-upgrade-gemspec-git branch August 23, 2020 22:14
Adapt GemspecGit cop With the introduction of new API.
cf: https://docs.rubocop.org/rubocop/0.87/v1_upgrade_notes.html

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants