Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML id attribute in cops_packaging.adoc #32

Conversation

koic
Copy link
Collaborator

@koic koic commented Oct 19, 2020

This PR fixes the following HTML id attribute in cops_packaging.adoc.

% git grep require-relative-hardcoding-lib-rationale
docs/modules/ROOT/pages/cops_packaging.adoc:=== Rationale [[require-relative-hardcoding-lib-rationale]]
docs/modules/ROOT/pages/cops_packaging.adoc:=== Examples [[require-relative-hardcoding-lib-rationale]]

It will suppress the following warning that generates docs.rubocop.org.

$ cd docs.rubocop.org
$ antora --pull antora-playbook.yml
(snip)

asciidoctor: WARNING: cops_packaging.adoc: line 205: id assigned to
section already in use: require-relative-hardcoding-lib-rationale

This PR fixes the following HTML id attribute in cops_packaging.adoc.

```console
% git grep require-relative-hardcoding-lib-rationale
docs/modules/ROOT/pages/cops_packaging.adoc:=== Rationale
[[require-relative-hardcoding-lib-rationale]]
docs/modules/ROOT/pages/cops_packaging.adoc:=== Examples
[[require-relative-hardcoding-lib-rationale]]
```

It will suppress the following warning that generates docs.rubocop.org.

```console
$ cd docs.rubocop.org
$ antora --pull antora-playbook.yml
(snip)

asciidoctor: WARNING: cops_packaging.adoc: line 205: id assigned to
section already in use: require-relative-hardcoding-lib-rationale
```
Copy link
Owner

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @koic! ❤️

@utkarsh2102 utkarsh2102 merged commit f262d22 into utkarsh2102:master Oct 20, 2020
@koic koic deleted the fix_html_id_attribute_in_cop_packaging_adoc branch October 20, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants