Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring plugin options via INI file #10

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

arthurian
Copy link
Contributor

Hello,

We have a need to seed the plugin with configuration options prior to the plugin actually being installed. One way to do that is to run a bunch of database queries to insert the relevant key/value pairs into the options table. However, this PR provides an alternative by allowing site admins to configure the plugin options in options.ini ahead of time. When the plugin is installed, those options are picked up and override the existing defaults.

As its name implies, the options.ini file is completely optional, so if the file does not exist, the default options will be generated by the plugin as per usual and existing plugin clients will not be impacted by the change.

Any thoughts @dicksonlaw583? We intend to use this functionality in our ansible playbooks to pre-seed the options on a per-site basis since we have a bunch of sites we're managing that will use this plugin.

P.S. This is a fantastic plugin, so thank you for all your work on this!

@sarahloleet sarahloleet mentioned this pull request Feb 9, 2018
@arthurian
Copy link
Contributor Author

@dicksonlaw583 We're still actively using IiifItems in our multi-site Omeka deployment and just wanted to follow-up on this PR. Anything that would prevent this from being merged?

@dicksonlaw583
Copy link
Collaborator

My apologies for the delay in answering this PR. There is a new use case for Docker Compose where this feature will be useful, and so I will accept this PR. The corresponding documentation will be added shortly.

Thank you for your contribution to the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants